You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Varun Thacker (JIRA)" <ji...@apache.org> on 2018/06/19 12:10:00 UTC
[jira] [Commented] (SOLR-12489) Restore collection does not respect
user specified replicationFactor
[ https://issues.apache.org/jira/browse/SOLR-12489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516995#comment-16516995 ]
Varun Thacker commented on SOLR-12489:
--------------------------------------
Patch where I've beasted the backup/restore tests.
Going to run all the tests and precommit before committing it
> Restore collection does not respect user specified replicationFactor
> --------------------------------------------------------------------
>
> Key: SOLR-12489
> URL: https://issues.apache.org/jira/browse/SOLR-12489
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Varun Thacker
> Assignee: Varun Thacker
> Priority: Major
> Labels: Backup/Restore
> Attachments: SOLR-12489.patch
>
>
> When restoring a collection we can pass in the replicationFactor
> However while restoring the collection we don't make use of this param and end up using whatever is present as the nrtReplicas key in the state.json
>
> {code:java}
> int numNrtReplicas = getInt(message, NRT_REPLICAS, backupCollectionState.getNumNrtReplicas(), 0);
> if (numNrtReplicas == 0) {
> numNrtReplicas = getInt(message, REPLICATION_FACTOR, backupCollectionState.getReplicationFactor(), 0);
> }{code}
> The tests didn't catch this as the create collection call from SolrJ sets nrtReplicas = replicationFactor and then we never restore with a different replicationFactor
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org