[GitHub] [spark] itholic commented on a diff in pull request #42762: [SPARK-42309][SQL][FOLLOWUP] Raise exception directly instead of calling `resolveColumnsByPosition`

["itholic (via GitHub)" <gi...@apache.org>]

itholic commented on code in PR #42762:
URL: https://github.com/apache/spark/pull/42762#discussion_r1312534942


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala:
##########
@@ -111,7 +111,9 @@ object TableOutputResolver {
     }
 
     if (errors.nonEmpty) {
-      resolveColumnsByPosition(tableName, query.output, actualExpectedCols, conf, errors += _)
+      throw QueryCompilationErrors.incompatibleDataToTableCannotFindDataError(

Review Comment:
   I'm not 100% sure, but I think strongly suspect that there are possible reason:
   - No test to cover this case.
   - It is being tested in an incorrect way somewhere.
   
   Let's waiting for the CI for now. I believe we could find some reason after then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org