[GitHub] [geode] metatype opened pull request #2882: GEODE-6075 Improve tests using the geode version

["metatype (GitHub)" <gi...@apache.org>]

Currently several tests check the geode assembly for correctness using
fixed information, including the geode version.  Every time we bump the
geode version these tests fail and we have to update the comparison
files.  This change skips strict version checks on the geode version
while retaining presence detection (e.g. if geode-core-*.jar was missing
the test will still fail).

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [X] Is your initial contribution a single, squashed commit?

- [X] Does `gradlew build` run cleanly?

- [X] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype commented on issue #2882: GEODE-6075 Improve tests using the geode version

["metatype (GitHub)" <gi...@apache.org>]

@nabarunnag You should only need to touch the files if there are dependency changes (either version or add/remove) or a geode module is added or removed.

[ Full content available at: https://github.com/apache/geode/pull/2882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] nabarunnag commented on issue #2882: GEODE-6075 Improve tests using the geode version

["nabarunnag (GitHub)" <gi...@apache.org>]

So what steps should we take when are releasing a version. For e.g. if I am releasing 1.9, will I still have to update dependency_classpath.txt and assembly_context.txt from 0.0.0 to 1.9.0 for the files even though the tests do not fail?

[ Full content available at: https://github.com/apache/geode/pull/2882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] metatype closed pull request #2882: GEODE-6075 Improve tests using the geode version

["metatype (GitHub)" <gi...@apache.org>]

[ pull request closed by metatype ]

[ Full content available at: https://github.com/apache/geode/pull/2882 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org