You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/11/24 03:40:44 UTC

[GitHub] [servicecomb-java-chassis] wujimin opened a new pull request #2075: [SCB-2122] consumer interface support default method

wujimin opened a new pull request #2075:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2075


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-io edited a comment on pull request #2075: [SCB-2122] consumer interface support default method

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2075:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2075#issuecomment-732640218


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=h1) Report
   > Merging [#2075](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=desc) (9b115f4) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/1a7d4a90d1b7df48b9cd7e2792ec153cbe7e5a41?el=desc) (1a7d4a9) will **decrease** coverage by `0.02%`.
   > The diff coverage is `17.14%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2075      +/-   ##
   ============================================
   - Coverage     81.52%   81.49%   -0.03%     
     Complexity     1295     1295              
   ============================================
     Files          1429     1431       +2     
     Lines         39113    39148      +35     
     Branches       3333     3334       +1     
   ============================================
   + Hits          31888    31905      +17     
   - Misses         5780     5796      +16     
   - Partials       1445     1447       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/servicecomb/it/testcase/TestDefaultMethod.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-aW50ZWdyYXRpb24tdGVzdHMvaXQtY29uc3VtZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2l0L3Rlc3RjYXNlL1Rlc3REZWZhdWx0TWV0aG9kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...e/servicecomb/provider/pojo/DefaultMethodMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vRGVmYXVsdE1ldGhvZE1ldGEuamF2YQ==) | `15.00% <15.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../org/apache/servicecomb/provider/pojo/Invoker.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vSW52b2tlci5qYXZh) | `80.64% <25.00%> (-8.25%)` | `0.00 <0.00> (ø)` | |
   | [...comb/swagger/generator/core/utils/MethodUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-c3dhZ2dlci9zd2FnZ2VyLWdlbmVyYXRvci9nZW5lcmF0b3ItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc3dhZ2dlci9nZW5lcmF0b3IvY29yZS91dGlscy9NZXRob2RVdGlscy5qYXZh) | `90.62% <100.00%> (-6.05%)` | `0.00 <0.00> (ø)` | |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `90.00% <0.00%> (-3.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...omb/codec/protobuf/definition/ProtobufManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1wcm90b2J1Zi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29kZWMvcHJvdG9idWYvZGVmaW5pdGlvbi9Qcm90b2J1Zk1hbmFnZXIuamF2YQ==) | `70.73% <0.00%> (-2.44%)` | `0.00% <0.00%> (ø%)` | |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.26% <0.00%> (+1.16%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [3 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=footer). Last update [1a7d4a9...9b115f4](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2075: [SCB-2122] consumer interface support default method

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2075:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2075#issuecomment-732640218


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=h1) Report
   > Merging [#2075](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=desc) (015b1b5) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/1a7d4a90d1b7df48b9cd7e2792ec153cbe7e5a41?el=desc) (1a7d4a9) will **decrease** coverage by `0.03%`.
   > The diff coverage is `13.79%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2075      +/-   ##
   ============================================
   - Coverage     81.52%   81.49%   -0.04%     
     Complexity     1295     1295              
   ============================================
     Files          1429     1431       +2     
     Lines         39113    39142      +29     
     Branches       3333     3333              
   ============================================
   + Hits          31888    31898      +10     
   - Misses         5780     5797      +17     
   - Partials       1445     1447       +2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...che/servicecomb/it/testcase/TestDefaultMethod.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-aW50ZWdyYXRpb24tdGVzdHMvaXQtY29uc3VtZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2l0L3Rlc3RjYXNlL1Rlc3REZWZhdWx0TWV0aG9kLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...e/servicecomb/provider/pojo/DefaultMethodMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vRGVmYXVsdE1ldGhvZE1ldGEuamF2YQ==) | `15.00% <15.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../org/apache/servicecomb/provider/pojo/Invoker.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vSW52b2tlci5qYXZh) | `80.64% <25.00%> (-8.25%)` | `0.00 <0.00> (ø)` | |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `90.00% <0.00%> (-3.34%)` | `0.00% <0.00%> (ø%)` | |
   | [...ecomb/provider/pojo/PojoConsumerMetaRefresher.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-cHJvdmlkZXJzL3Byb3ZpZGVyLXBvam8vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL3Byb3ZpZGVyL3Bvam8vUG9qb0NvbnN1bWVyTWV0YVJlZnJlc2hlci5qYXZh) | `75.60% <0.00%> (-2.44%)` | `0.00% <0.00%> (ø%)` | |
   | [...omb/codec/protobuf/definition/ProtobufManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-Y29tbW9uL2NvbW1vbi1wcm90b2J1Zi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29kZWMvcHJvdG9idWYvZGVmaW5pdGlvbi9Qcm90b2J1Zk1hbmFnZXIuamF2YQ==) | `70.73% <0.00%> (-2.44%)` | `0.00% <0.00%> (ø%)` | |
   | [...egistry/client/http/ServiceRegistryClientImpl.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1NlcnZpY2VSZWdpc3RyeUNsaWVudEltcGwuamF2YQ==) | `71.26% <0.00%> (+1.16%)` | `0.00% <0.00%> (ø%)` | |
   | [...mb/serviceregistry/client/http/RestClientUtil.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree#diff-c2VydmljZS1yZWdpc3RyeS9yZWdpc3RyeS1zZXJ2aWNlLWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvc2VydmljZXJlZ2lzdHJ5L2NsaWVudC9odHRwL1Jlc3RDbGllbnRVdGlsLmphdmE=) | `77.57% <0.00%> (+1.86%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [1 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=footer). Last update [1a7d4a9...9b115f4](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2075?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2075: [SCB-2122] consumer interface support default method

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2075:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2075


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org