You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Bill Tutt <bi...@microsoft.com> on 2001/08/15 06:40:22 UTC

Compiling problems with ra_dav on Win32

I'd have looked into fixes, but wasn't sure whether I should given
Karl's pronouncement.

Compiling neon 0.15.3 actually worked, and after pointing ra_dav where
the neon header files where it generated the following output:

Compiling...
commit.c
c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
C4090: 'function' : different 'const' qualifiers
c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
C4022: 'ne_add_response_header_handler' : pointer mismatch for actual
parameter 4
....
session.c
c:\svn\subversion\subversion\libsvn_ra_dav\session.c(146) : warning
C4013: 'strcasecmp' undefined; assuming extern returning int

FYI,
Bill

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Compiling problems with ra_dav on Win32

Posted by kf...@collab.net.
Greg Stein <gs...@lyra.org> writes:
> When we are ready, the repository should be tagged and then commit access
> disabled. By definition, nothing can get in after that.

By the way, although we will certainly tag the repository, we can't
just lock it down yet (for stupid technical reasons, it's currently
our only method of updating the web site -- so until that's fixed,
there will be parallel commits in the www/ area.  I'll take care of
keeping them in sync until we have that situation solved.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Compiling problems with ra_dav on Win32

Posted by kf...@collab.net.
Greg Stein <gs...@lyra.org> writes:
> > Well, no, please don't check in even tweaks like this -- unless you're
> > prepared to remember them, look for them in the new repository when it
> > goes live, and re-check them in if they're absent.
> 
> When we are ready, the repository should be tagged and then commit access
> disabled. By definition, nothing can get in after that.

Yes, but that doesn't address the issue of changes coming in *while*
we're working on the release.

> > Because if you happen to check it in after we've rolled the dist
> > tarball and created the new repository, then your changes can't be
> > easily included without redoing the import and/or re-rolling the
> > tarball, which would of course imply re-testing it...
> 
> Karl. You're being tweaky. Bill and I just discussed a *cast* and an extra
> #include to clear up warnings. There is zero problem checking them in.

Greg, I'm not being tweaky.  Think about the process here.  It doesn't
matter whether the changes are known to be safe; the issue is that
either a) a tarball might have to be rebuilt and put in the download
location *again*, or b) Bill would have to remember to reapply his
commits.

If Bill is confident that he'll do (b), then it's fine.  But I don't
want to have to do (a), because once we get that thing built, I want
to go home, not sit here rebuilding dists, which takes time even if
they don't need to be tested.  

...And they do need to be tested, anyway; distribution paranoia has
paid off for me too many times in the past to disregard it now.

> Go look at some of the other commits if you want to find problems.

?

> Now that you've delayed his checkin, yes: maybe they will miss.

I think Bill knows how to handle this; certainly he hasn't complained
about it.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Compiling problems with ra_dav on Win32

Posted by Greg Stein <gs...@lyra.org>.
On Wed, Aug 15, 2001 at 10:20:04AM -0500, kfogel@collab.net wrote:
> Greg Stein <gs...@lyra.org> writes:
> > > I'd have looked into fixes, but wasn't sure whether I should given
> > > Karl's pronouncement.
> > 
> > Tweaks like this are quite fine. Karl's simply trying to preclude somebody
> > checking in a new mechanism for storing WC information :-)
> 
> Well, no, please don't check in even tweaks like this -- unless you're
> prepared to remember them, look for them in the new repository when it
> goes live, and re-check them in if they're absent.

When we are ready, the repository should be tagged and then commit access
disabled. By definition, nothing can get in after that.

> Because if you happen to check it in after we've rolled the dist
> tarball and created the new repository, then your changes can't be
> easily included without redoing the import and/or re-rolling the
> tarball, which would of course imply re-testing it...

Karl. You're being tweaky. Bill and I just discussed a *cast* and an extra
#include to clear up warnings. There is zero problem checking them in.

Go look at some of the other commits if you want to find problems.

Now that you've delayed his checkin, yes: maybe they will miss.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Compiling problems with ra_dav on Win32

Posted by kf...@collab.net.
Greg Stein <gs...@lyra.org> writes:
> > I'd have looked into fixes, but wasn't sure whether I should given
> > Karl's pronouncement.
> 
> Tweaks like this are quite fine. Karl's simply trying to preclude somebody
> checking in a new mechanism for storing WC information :-)

Well, no, please don't check in even tweaks like this -- unless you're
prepared to remember them, look for them in the new repository when it
goes live, and re-check them in if they're absent.

Because if you happen to check it in after we've rolled the dist
tarball and created the new repository, then your changes can't be
easily included without redoing the import and/or re-rolling the
tarball, which would of course imply re-testing it...

Better to hang onto *any* non-M3 changes and check them in tomorrow.
I mean, it's only a day. :-)

[One might say "Yes, but the whole problem is that I'm working on a
Windows machine, and I won't have a working Subversion without these
fixes."  To which I say: "If the fixes really fix it, then you *will*
have a working Subversion client, right?" :-) ]

Thanks,
-K

> >...
> > Compiling...
> > commit.c
> > c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
> > C4090: 'function' : different 'const' qualifiers
> > c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
> > C4022: 'ne_add_response_header_handler' : pointer mismatch for actual
> > parameter 4
> 
> No idea here. It seems like it thinks "const char **" cannot be passed as a
> "void *". Bogus, but that might be it. Try adding a void* cast in there to
> see what happens. If it shuts the thing down, then go ahead. (with a comment
> on why the cast exists)
> 
> > ....
> > session.c
> > c:\svn\subversion\subversion\libsvn_ra_dav\session.c(146) : warning
> > C4013: 'strcasecmp' undefined; assuming extern returning int
> 
> Try adding #include <apr_general.h> to the top of the file. Hopefully, that
> will fix it.
> 
> 
> If the changes work, then go ahead and check them in.
> 
> Cheers,
> -g
> 
> -- 
> Greg Stein, http://www.lyra.org/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Compiling problems with ra_dav on Win32

Posted by Greg Stein <gs...@lyra.org>.
On Tue, Aug 14, 2001 at 11:40:22PM -0700, Bill Tutt wrote:
> I'd have looked into fixes, but wasn't sure whether I should given
> Karl's pronouncement.

Tweaks like this are quite fine. Karl's simply trying to preclude somebody
checking in a new mechanism for storing WC information :-)

>...
> Compiling...
> commit.c
> c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
> C4090: 'function' : different 'const' qualifiers
> c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
> C4022: 'ne_add_response_header_handler' : pointer mismatch for actual
> parameter 4

No idea here. It seems like it thinks "const char **" cannot be passed as a
"void *". Bogus, but that might be it. Try adding a void* cast in there to
see what happens. If it shuts the thing down, then go ahead. (with a comment
on why the cast exists)

> ....
> session.c
> c:\svn\subversion\subversion\libsvn_ra_dav\session.c(146) : warning
> C4013: 'strcasecmp' undefined; assuming extern returning int

Try adding #include <apr_general.h> to the top of the file. Hopefully, that
will fix it.


If the changes work, then go ahead and check them in.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Compiling problems with ra_dav on Win32

Posted by kf...@collab.net.
"Bill Tutt" <bi...@microsoft.com> writes:
> I'd have looked into fixes, but wasn't sure whether I should given
> Karl's pronouncement.

Oh, I didn't mean people shouldn't continue to work!  Just don't
commit non-M3 changes.  Post patches, or just hang on to them until
after the switchover, that's all.

-K


> Compiling neon 0.15.3 actually worked, and after pointing ra_dav where
> the neon header files where it generated the following output:
> 
> Compiling...
> commit.c
> c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
> C4090: 'function' : different 'const' qualifiers
> c:\svn\subversion\subversion\libsvn_ra_dav\commit.c(361) : warning
> C4022: 'ne_add_response_header_handler' : pointer mismatch for actual
> parameter 4
> ....
> session.c
> c:\svn\subversion\subversion\libsvn_ra_dav\session.c(146) : warning
> C4013: 'strcasecmp' undefined; assuming extern returning int
> 
> FYI,
> Bill
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org