[jira] [Comment Edited] (SLING-6855) Create ResultRegistry to provide health check behavior for executing code that does not want a HealthCheck

["Georg Henzler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-6855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010161#comment-16010161 ] 

Georg Henzler edited comment on SLING-6855 at 5/15/17 8:38 AM:
---------------------------------------------------------------

Just a thought before we proceed with a "hc internal" implementation: Could it be easier/better to just record metrics? There could be a health check property (e.g. {{hc.registerMeters}}) that registers meters for WARN and CRITICAL automatically (one each, a name convention could be hc.name + WARN/CRITICAL). Then we can provide a generic, configurable check for metrics meters (that can catch the metrics from the above HC or even of any other meters). 

The advantage would be less code to maintain and that metrics (that might already be monitored elsewhere anyway) include information about the HC history.

[~cgoudie] WDYT?


was (Author: henzlerg):
Just a thought before we proceed with a "hc internal" implementation: Could it be easier/better to just record metrics? There could be health check property (e.g. {{hc.registerMeters}}) that registers meters for WARN and CRITICAL automatically (one each, a name convention could be hc.name + WARN/CRITICAL). Then we can provide a generic, configurable check for metrics meters (that can catch the metrics from the above HC or even of any other meters). 

The advantage would be less code to maintain and that metrics (that might already be monitored elsewhere) include information about the HC history.

[~cgoudie] WDYT?

> Create ResultRegistry to provide health check behavior for executing code that does not want a HealthCheck
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SLING-6855
>                 URL: https://issues.apache.org/jira/browse/SLING-6855
>             Project: Sling
>          Issue Type: New Feature
>          Components: Health Check
>            Reporter: Clinton H Goudie-Nice
>
> I want to provide a Registry service that can be leveraged to provide health check results.
> These results can be for a period of time through an expiration, until the JVM is restarted, or added and later removed.
> This can be useful when code observes a specific (possibly bad) state, and wants to alert through the health check API that this state has taken place.
>  Some examples: 
>  An event pool has filled, and some events will be thrown away.
>   This is a failure case that requires a restart of the instance.
>   It would be appropriate to trigger a permanent failure.
>    
>  A quota has been tripped. This quota may immediately recover, but it is sensible to alert for 30 minutes that the quota has been tripped.
>  If you expect the failure will clear itself within a certain window, setting the expiration to that window can be ideal.
> GHPR to follow



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)