[jira] [Commented] (SPARK-37011) Upgrade flake8 to 3.9.0 or above in Jenkins

["Shane Knapp (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-37011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433916#comment-17433916 ] 

Shane Knapp commented on SPARK-37011:
-------------------------------------

done.

 
{noformat}
(py36) jenkins@research-jenkins-worker-01:~/sknapp/spark/dev$ python
Python 3.6.8 |Anaconda, Inc.| (default, Dec 30 2018, 01:22:34)
[GCC 7.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import flake8
>>> flake8.__version__
'3.9.0'
>>>
(py36) jenkins@research-jenkins-worker-01:~/sknapp/spark/dev$ ./lint-python
starting python compilation test...
python compilation succeeded.

The python3 -m black command was not found. Skipping black checks for now.

downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.7.0/pycodestyle.py...
starting pycodestyle test...
pycodestyle checks passed.

starting flake8 test...
flake8 checks passed.

The mypy command was not found. Skipping for now.

all lint-python tests passed!{noformat}

> Upgrade flake8 to 3.9.0 or above in Jenkins
> -------------------------------------------
>
>                 Key: SPARK-37011
>                 URL: https://issues.apache.org/jira/browse/SPARK-37011
>             Project: Spark
>          Issue Type: Improvement
>          Components: PySpark
>    Affects Versions: 3.3.0
>            Reporter: Takuya Ueshin
>            Priority: Major
>
> In flake8 < 3.9.0, F401 error occurs for imports when the imported identities are used in a {{bound}} argument in {{TypeVar(..., bound="XXX")}}.
> For example:
> {code:python}
> if TYPE_CHECKING:
>     from pyspark.pandas.base import IndexOpsMixin
> IndexOpsLike = TypeVar("IndexOpsLike", bound="IndexOpsMixin")
> {code}
> Since this behavior is fixed In flake8 >= 3.9.0, we should upgrade the flake8 installed in Jenkins to 3.9.0 or above.
> And also we might update the {{MINIMUM_FLAKE8}} in the {{lint-python}} from 3.8.0 to 3.9.0.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org