You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by GitBox <gi...@apache.org> on 2021/04/12 07:21:44 UTC
[GitHub] [trafficserver] udbxtd2008 opened a new issue #7699: write_dns_event may cause underflow when proxy.config.dns.retries is changed
udbxtd2008 opened a new issue #7699:
URL: https://github.com/apache/trafficserver/issues/7699
Position of the problem:
write_dns_event DNS.cc line 1140: e->id[dns_retries - e->retries] = i;
1. e->retries was assinged with dns_retries in DNSProcessor::getby.
2. The value of dns_retries is combined with "proxy.config.dns.retries".
3. if "proxy.config.dns.retries" is changed to be a smaller value by traffic_ctl， for example:
/opt/ats/bin/traffic_ctl config set proxy.config.dns.retries 9 -- > 0.
4. [dns_retries - e->retries] will underflow. The memory before id[] will be writen by wrong value.
struct DNSEntry : public Continuation {
int id[MAX_DNS_RETRIES];
...
Solution:
Consider assign dns_retries to DNSEntry in DNSProcessor::getby?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on issue #7699: write_dns_event may cause underflow when proxy.config.dns.retries is changed
Posted by GitBox <gi...@apache.org>.
bryancall commented on issue #7699:
URL: https://github.com/apache/trafficserver/issues/7699#issuecomment-1061294618
We should set proxy.config.dns.retries not be a dynamic config for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall closed issue #7699: write_dns_event may cause underflow when proxy.config.dns.retries is changed
Posted by GitBox <gi...@apache.org>.
bryancall closed issue #7699:
URL: https://github.com/apache/trafficserver/issues/7699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on issue #7699: write_dns_event may cause underflow when proxy.config.dns.retries is changed
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on issue #7699:
URL: https://github.com/apache/trafficserver/issues/7699#issuecomment-842695786
I am looking at this but I've found some other, rather more serious issues. I'll try to work this in as I go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org