You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/11/14 21:09:00 UTC

[jira] [Work logged] (CAMEL-14184) Allow setting Pulsar Message headers (properties, event time, key) when producing

     [ https://issues.apache.org/jira/browse/CAMEL-14184?focusedWorklogId=343746&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-343746 ]

ASF GitHub Bot logged work on CAMEL-14184:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Nov/19 21:08
            Start Date: 14/Nov/19 21:08
    Worklog Time Spent: 10m 
      Work Description: williamthompson-toast commented on pull request #3340: CAMEL-14184: Allow setting Pulsar Message properties, event_time, key fields
URL: https://github.com/apache/camel/pull/3340
 
 
   Addresses [CAMEL-14184](https://issues.apache.org/jira/browse/CAMEL-14184)
   
   ### Motivation
   Setting properties on a message is a useful feature for passing along metadata. It was possible to set before https://github.com/apache/camel/commit/3487139d32eb153c30699ce68e5da559f5398082#diff-78ab2639e805ed21d4a401cab24e768a , but was removed. Key is required for key-shared subscription modes. And event_time is useful metadata that can be used for deduping. 
   
   ### Modifications
   The fix proposed in this PR is to pull the values from the Camel message headers (documented in the adoc) using a naming scheme similar to other header values and using the TypedMessageBuilder to add them to the Pulsar message object. I've also documented the headers coming in from the consumer, since they were missing from the documentation and potentially useful to know. 
   
   ### Testing
   `PulsarProducerHeadersInTest.java `: Used to verify that the headers get used correctly for the 3 producer headers.
   
   ### Documentation
   Modified `pulsar-component.adoc` with updated information describing headers that will modify the Pulsar producer message headers and the messages that are already being set by the Pulsar consumer.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 343746)
    Remaining Estimate: 0h
            Time Spent: 10m

> Allow setting Pulsar Message headers (properties, event time, key) when producing
> ---------------------------------------------------------------------------------
>
>                 Key: CAMEL-14184
>                 URL: https://issues.apache.org/jira/browse/CAMEL-14184
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-pulsar
>    Affects Versions: 2.24.2, 3.x
>            Reporter: William Thompson
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> There used to be the ability to set Pulsar Message properties, but got lost during the speed-up of the component: https://github.com/apache/camel/commit/3487139d32eb153c30699ce68e5da559f5398082#diff-78ab2639e805ed21d4a401cab24e768a
> This improvement is to allow setting most, if not all, useful Pulsar Message values that can be done through the MessageBuilder.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)