You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/09 04:49:29 UTC
[GitHub] [spark] pan3793 opened a new pull request, #36485: [SPARK-39128][SQL][HIVE] Log cost time for Get FileStatus in HadoopTableReader
pan3793 opened a new pull request, #36485:
URL: https://github.com/apache/spark/pull/36485
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Log cost time for `fs.globStatus(pathPattern)` in HadoopTableReader
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Sometimes `fs.globStatus(pathPattern)` costs unreasonable time, but there is not log for recording.
<img width="871" alt="image" src="https://user-images.githubusercontent.com/26535726/167342533-5d4949fb-9675-4398-b15e-af6c603ac92e.png">
<img width="1690" alt="image" src="https://user-images.githubusercontent.com/26535726/167342563-f19c1fff-23b6-4f89-ad00-71c9c4b7125b.png">
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing UT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #36485:
URL: https://github.com/apache/spark/pull/36485#discussion_r868219599
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
##########
@@ -175,7 +175,8 @@ class HadoopTableReader(
def updateExistPathSetByPathPattern(pathPatternStr: String): Unit = {
val pathPattern = new Path(pathPatternStr)
val fs = pathPattern.getFileSystem(hadoopConf)
- val matches = fs.globStatus(pathPattern)
+ val (matches, timeCost) = Utils.timeTakenMs(fs.globStatus(pathPattern))
+ logInfo(s"Get FileStatus for path '$pathPatternStr' costs $timeCost ms.")
Review Comment:
logDebug?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #36485:
URL: https://github.com/apache/spark/pull/36485#discussion_r868761212
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
##########
@@ -175,7 +175,8 @@ class HadoopTableReader(
def updateExistPathSetByPathPattern(pathPatternStr: String): Unit = {
val pathPattern = new Path(pathPatternStr)
val fs = pathPattern.getFileSystem(hadoopConf)
- val matches = fs.globStatus(pathPattern)
+ val (matches, timeCost) = Utils.timeTakenMs(fs.globStatus(pathPattern))
+ logInfo(s"Get FileStatus for path '$pathPatternStr' costs $timeCost ms.")
Review Comment:
OK, I don't feel super strongly about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #36485:
URL: https://github.com/apache/spark/pull/36485#discussion_r868751869
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
##########
@@ -175,7 +175,8 @@ class HadoopTableReader(
def updateExistPathSetByPathPattern(pathPatternStr: String): Unit = {
val pathPattern = new Path(pathPatternStr)
val fs = pathPattern.getFileSystem(hadoopConf)
- val matches = fs.globStatus(pathPattern)
+ val (matches, timeCost) = Utils.timeTakenMs(fs.globStatus(pathPattern))
+ logInfo(s"Get FileStatus for path '$pathPatternStr' costs $timeCost ms.")
Review Comment:
Personally, I prefer to use logInfo, because
1) the message is not noisy, `pathPatternStr` matches the table path, which means if the query access 10 tables, just generate 10 messages.
2) the PR itself aims to give more information when the user's job is stuck on listing files, the most important information is `pathPatternStr`, and I suppose most users will not turn on debug level log on production, then users have less opportunity to this message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36485:
URL: https://github.com/apache/spark/pull/36485#issuecomment-1120709655
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #36485:
URL: https://github.com/apache/spark/pull/36485#issuecomment-1254360769
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
URL: https://github.com/apache/spark/pull/36485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #36485:
URL: https://github.com/apache/spark/pull/36485#discussion_r873808592
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
##########
@@ -175,7 +175,8 @@ class HadoopTableReader(
def updateExistPathSetByPathPattern(pathPatternStr: String): Unit = {
val pathPattern = new Path(pathPatternStr)
val fs = pathPattern.getFileSystem(hadoopConf)
- val matches = fs.globStatus(pathPattern)
+ val (matches, timeCost) = Utils.timeTakenMs(fs.globStatus(pathPattern))
+ logInfo(s"Get FileStatus for path '$pathPatternStr' costs $timeCost ms.")
Review Comment:
@srowen Do you have any concerns before merging it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a diff in pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
srowen commented on code in PR #36485:
URL: https://github.com/apache/spark/pull/36485#discussion_r873811257
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
##########
@@ -175,7 +175,8 @@ class HadoopTableReader(
def updateExistPathSetByPathPattern(pathPatternStr: String): Unit = {
val pathPattern = new Path(pathPatternStr)
val fs = pathPattern.getFileSystem(hadoopConf)
- val matches = fs.globStatus(pathPattern)
+ val (matches, timeCost) = Utils.timeTakenMs(fs.globStatus(pathPattern))
+ logInfo(s"Get FileStatus for path '$pathPatternStr' costs $timeCost ms.")
Review Comment:
I'm neutral, would not merge it but do not object to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on a diff in pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #36485:
URL: https://github.com/apache/spark/pull/36485#discussion_r873816933
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/TableReader.scala:
##########
@@ -175,7 +175,8 @@ class HadoopTableReader(
def updateExistPathSetByPathPattern(pathPatternStr: String): Unit = {
val pathPattern = new Path(pathPatternStr)
val fs = pathPattern.getFileSystem(hadoopConf)
- val matches = fs.globStatus(pathPattern)
+ val (matches, timeCost) = Utils.timeTakenMs(fs.globStatus(pathPattern))
+ logInfo(s"Get FileStatus for path '$pathPatternStr' costs $timeCost ms.")
Review Comment:
emm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] pan3793 commented on pull request #36485: [SPARK-39128][SQL][HIVE] Log cost time for getting FileStatus in HadoopTableReader
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #36485:
URL: https://github.com/apache/spark/pull/36485#issuecomment-1127767757
cc @yaooqinn would you please take a look if you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org