You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by vvysotskyi <gi...@git.apache.org> on 2017/10/09 12:28:18 UTC

[GitHub] drill pull request #980: DRILL-5857: Fix NumberFormatException in Hive unit ...

GitHub user vvysotskyi opened a pull request:

    https://github.com/apache/drill/pull/980

    DRILL-5857: Fix NumberFormatException in Hive unit tests

    There is no unit test since with or without this change tests are passes and query plan does not change. 
    
    The exception that has been appeared caught and wrote into the logs.
    After the check on [this line](https://github.com/apache/drill/blob/3e8b01d5b0d3013e3811913f0fd6028b22c1ac3f/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveMetadataProvider.java#L90), correct stats was created calling [getStatsEstimateFromInputSplits()](https://github.com/apache/drill/blob/3e8b01d5b0d3013e3811913f0fd6028b22c1ac3f/contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveMetadataProvider.java#L95) method.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vvysotskyi/drill DRILL-5857

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/980.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #980
    
----
commit 24be497469a976fb51c16c0474774229e44fcc71
Author: Volodymyr Vysotskyi <vv...@gmail.com>
Date:   2017-10-09T14:28:42Z

    DRILL-5857: Fix NumberFormatException in Hive unit tests

----


---

[GitHub] drill issue #980: DRILL-5857: Fix NumberFormatException in Hive unit tests

Posted by arina-ielchiieva <gi...@git.apache.org>.

Github user arina-ielchiieva commented on the issue:

    https://github.com/apache/drill/pull/980
  
    +1, LGTM.


---

[GitHub] drill pull request #980: DRILL-5857: Fix NumberFormatException in Hive unit ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/980


---