You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/07/19 00:38:17 UTC

Review Request 23696: Made LoadGeneratorFramework a check program instead of a bin program.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23696/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-1591
    https://issues.apache.org/jira/browse/MESOS-1591


Repository: mesos-git


Description
-------

Changed the deployment method for this framework to be packaging libmesos.so and load-generator-framework binaries together in a tarball.


Diffs
-----

  src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25 

Diff: https://reviews.apache.org/r/23696/diff/


Testing
-------

Ran this tarball package as an Aurora job with the following command:

LD_LIBRARY_PATH=. ./load-generator-framework \
--master=zk://<zkpass> \
--qps=5000 \
--secret=<password_file> \
--authenticate \ 
--duration=1mins


Thanks,

Jiang Yan Xu


Re: Review Request 23696: Made LoadGeneratorFramework a check program instead of a bin program.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23696/#review48437
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23696]

All tests passed.

- Mesos ReviewBot


On July 18, 2014, 10:38 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23696/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 10:38 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1591
>     https://issues.apache.org/jira/browse/MESOS-1591
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Changed the deployment method for this framework to be packaging libmesos.so and load-generator-framework binaries together in a tarball.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25 
> 
> Diff: https://reviews.apache.org/r/23696/diff/
> 
> 
> Testing
> -------
> 
> Ran this tarball package as an Aurora job with the following command:
> 
> LD_LIBRARY_PATH=. ./load-generator-framework \
> --master=zk://<zkpass> \
> --qps=5000 \
> --secret=<password_file> \
> --authenticate \ 
> --duration=1mins
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Re: Review Request 23696: Made LoadGeneratorFramework a check program instead of a bin program.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23696/#review48277
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On July 18, 2014, 10:38 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23696/
> -----------------------------------------------------------
> 
> (Updated July 18, 2014, 10:38 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1591
>     https://issues.apache.org/jira/browse/MESOS-1591
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Changed the deployment method for this framework to be packaging libmesos.so and load-generator-framework binaries together in a tarball.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am c216e2ffec3ad850ecebe5a841b7f1d6e053cc25 
> 
> Diff: https://reviews.apache.org/r/23696/diff/
> 
> 
> Testing
> -------
> 
> Ran this tarball package as an Aurora job with the following command:
> 
> LD_LIBRARY_PATH=. ./load-generator-framework \
> --master=zk://<zkpass> \
> --qps=5000 \
> --secret=<password_file> \
> --authenticate \ 
> --duration=1mins
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>