[jira] [Commented] (HBASE-7673) Incorrect error logging when a replication peer is removed

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13562723#comment-13562723 ] 

Hadoop QA commented on HBASE-7673:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12566506/HBASE-7673.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.coprocessor.example.TestBulkDeleteProtocol

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/4179//console

This message is automatically generated.
                
> Incorrect error logging when a replication peer is removed
> ----------------------------------------------------------
>
>                 Key: HBASE-7673
>                 URL: https://issues.apache.org/jira/browse/HBASE-7673
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 0.96.0
>            Reporter: Gabriel Reid
>            Priority: Minor
>         Attachments: HBASE-7673.patch
>
>
> When a replication peer is removed (and all goes well), the following error is still logged:
> {noformat}[ERROR][14:14:21,504][ventThread] org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager - The queue we wanted to close is missing peer-state{noformat}
> This is due to a watch being set on the peer-state node under the replication peer node in ZooKeeper, and the ReplicationSource#PeersWatcher doesn't correctly discern between nodes when it gets nodeDeleted messages.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira