[GitHub] [spark] LuciferYang commented on a diff in pull request #36787: [SPARK-39387][FOLLOWUP][TESTS] Add a test case for HIVE-25190

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #36787:
URL: https://github.com/apache/spark/pull/36787#discussion_r903232263


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcQuerySuite.scala:
##########
@@ -832,6 +832,18 @@ abstract class OrcQuerySuite extends OrcQueryTest with SharedSparkSession {
       }
     }
   }
+
+  test("SPARK-39387: BytesColumnVector should not throw RuntimeException due to overflow") {

Review Comment:
   > ```shell
   > ```shell
   > build/mvn -Dtest=none -DwildcardSuites=org.apache.spark.sql.execution.datasources.orc.OrcV1QuerySuite test
   > ```
   > 
   > 
   >     
   >       
   >     
   > 
   >       
   >     
   > 
   >     
   >   
   > ```
   
   
   When mvn test the whole `sql/core` module, it is easy to reproduce OOM on this case, even with Java 8. I think we should consider simplifying the case or increasing the test memory
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org