You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@fineract.apache.org by "adamsaghy (via GitHub)" <gi...@apache.org> on 2026/09/03 14:08:30 UTC

Re: [PR] FINERACT-2737: Return collateral name, unit price and percentage on l… [fineract]

adamsaghy commented on code in PR #6226:
URL: https://github.com/apache/fineract/pull/6226#discussion_r3925386024


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/data/LoanCollateralManagementData.java:
##########
@@ -35,4 +33,22 @@ public class LoanCollateralManagementData {
     private BigDecimal totalCollateral;
 
     private Long id;
+
+    private String name;
+
+    private BigDecimal unitPrice;
+
+    private BigDecimal pctToBase;
+
+    public LoanCollateralManagementData(Long clientCollateralId, BigDecimal quantity, BigDecimal total, BigDecimal totalCollateral, Long id,

Review Comment:
   We prefer @AllArgsConstructor over manual constructor. Please undo this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org