You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/04/07 10:18:05 UTC
[GitHub] [airflow] potiuk opened a new pull request, #30521: Enable AIP-44 and AIP-52 by default for development and CI on main
potiuk opened a new pull request, #30521:
URL: https://github.com/apache/airflow/pull/30521
The AIP-44 and AIP-52 are controlled now by environment variables, however those variables were not passed by default to inside the docker-compose environment so they had no effect when set on the ci.yaml. This PR fixes it, but it also sets the variables to be enabled by default in Breeze environment and when the tests are run locally in main using local venv so that the contributors are not surprised when they try to reproduce local failures.
In 2.6 branch, we will set both variables to "false" by default in ci.yml, so that the tests are not run when we cherry-pick the changes.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #30521: Enable AIP-44 and AIP-52 by default for development and CI on main
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #30521:
URL: https://github.com/apache/airflow/pull/30521#discussion_r1160664645
##########
scripts/ci/docker-compose/devcontainer.env:
##########
@@ -17,6 +17,8 @@
HOME=
AIRFLOW_CI_IMAGE="ghcr.io/apache/airflow/main/ci/python3.7:latest"
ANSWER=
+AIRFLOW_ENABLE_AIP_44="true"
+AIRFLOW_ENABLE_AIP_44="true"
Review Comment:
Should one be AIP 52 here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30521: Enable AIP-44 and AIP-52 by default for development and CI on main
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30521:
URL: https://github.com/apache/airflow/pull/30521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30521: Enable AIP-44 and AIP-52 by default for development and CI on main
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30521:
URL: https://github.com/apache/airflow/pull/30521#discussion_r1160726403
##########
scripts/ci/docker-compose/devcontainer.env:
##########
@@ -17,6 +17,8 @@
HOME=
AIRFLOW_CI_IMAGE="ghcr.io/apache/airflow/main/ci/python3.7:latest"
ANSWER=
+AIRFLOW_ENABLE_AIP_44="true"
+AIRFLOW_ENABLE_AIP_44="true"
Review Comment:
Very much so :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30521: Enable AIP-44 and AIP-52 by default for development and CI on main
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30521:
URL: https://github.com/apache/airflow/pull/30521#discussion_r1160609352
##########
tests/conftest.py:
##########
@@ -38,6 +38,8 @@
os.environ["AIRFLOW__CORE__UNIT_TEST_MODE"] = "True"
os.environ["AWS_DEFAULT_REGION"] = os.environ.get("AWS_DEFAULT_REGION") or "us-east-1"
os.environ["CREDENTIALS_DIR"] = os.environ.get("CREDENTIALS_DIR") or "/files/airflow-breeze-config/keys"
+os.environ["AIRFLOW_ENABLE_AIP_44"] = os.environ.get("AIRFLOW_ENABLE_AIP_44") or "true"
Review Comment:
This is the default if not set when our tests are run. This way the user wil not have to set the variables in their tests when they run in from the IDE (cc: @ephraimbuddy @jedcunningham @eladkal @pierrejeambrun ). I found it highly annoying that I had to set it in main - but still in airflow they will be disabled by default.
In CI in branch 2.6 we will set the vars to be "false" by default, so the tests will be skipped there - even if the change here will be part of 2.6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30521: Enable AIP-44 and AIP-52 by default for development and CI on main
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30521:
URL: https://github.com/apache/airflow/pull/30521#discussion_r1160726142
##########
scripts/ci/docker-compose/devcontainer.env:
##########
@@ -17,6 +17,8 @@
HOME=
AIRFLOW_CI_IMAGE="ghcr.io/apache/airflow/main/ci/python3.7:latest"
ANSWER=
+AIRFLOW_ENABLE_AIP_44="true"
+AIRFLOW_ENABLE_AIP_44="true"
Review Comment:
```suggestion
AIRFLOW_ENABLE_AIP_52="true"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org