You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/08/09 07:24:50 UTC
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #907: [KYUUBI #894] Enhance kyuubi-zookeeper module
pan3793 commented on a change in pull request #907:
URL: https://github.com/apache/incubator-kyuubi/pull/907#discussion_r684966249
##########
File path: kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/ZookeeperConf.scala
##########
@@ -87,26 +75,26 @@ object ZookeeperConf {
.intConf
.createWithDefault(120)
- val ZK_MIN_SESSION_TIMEOUT: OptionalConfigEntry[Int] =
+ val ZK_MIN_SESSION_TIMEOUT: ConfigEntry[Int] =
buildConf("zookeeper.embedded.min.session.timeout")
.doc("minSessionTimeout in milliseconds for the embedded zookeeper server will allow the" +
" client to negotiate. Defaults to 2 times the tickTime")
.version("1.2.0")
.intConf
- .createOptional
+ .createWithDefault(3000 * 2)
- val ZK_MAX_SESSION_TIMEOUT: OptionalConfigEntry[Int] =
+ val ZK_MAX_SESSION_TIMEOUT: ConfigEntry[Int] =
buildConf("zookeeper.embedded.max.session.timeout")
.doc("maxSessionTimeout in milliseconds for the embedded zookeeper server will allow the" +
" client to negotiate. Defaults to 20 times the tickTime")
.version("1.2.0")
.intConf
- .createOptional
+ .createWithDefault(3000 * 20)
- val ZK_SERVER_ID: ConfigEntry[Int] =
Review comment:
This is a breaking change, let mark it deprecated and useless first, then remove it after v1.3.0 release.
##########
File path: kyuubi-zookeeper/src/main/scala/org/apache/kyuubi/zookeeper/ZookeeperConf.scala
##########
@@ -87,26 +75,26 @@ object ZookeeperConf {
.intConf
.createWithDefault(120)
- val ZK_MIN_SESSION_TIMEOUT: OptionalConfigEntry[Int] =
+ val ZK_MIN_SESSION_TIMEOUT: ConfigEntry[Int] =
buildConf("zookeeper.embedded.min.session.timeout")
.doc("minSessionTimeout in milliseconds for the embedded zookeeper server will allow the" +
" client to negotiate. Defaults to 2 times the tickTime")
.version("1.2.0")
.intConf
- .createOptional
+ .createWithDefault(3000 * 2)
- val ZK_MAX_SESSION_TIMEOUT: OptionalConfigEntry[Int] =
+ val ZK_MAX_SESSION_TIMEOUT: ConfigEntry[Int] =
buildConf("zookeeper.embedded.max.session.timeout")
.doc("maxSessionTimeout in milliseconds for the embedded zookeeper server will allow the" +
" client to negotiate. Defaults to 20 times the tickTime")
.version("1.2.0")
.intConf
- .createOptional
+ .createWithDefault(3000 * 20)
- val ZK_SERVER_ID: ConfigEntry[Int] =
- buildConf("zookeeper.embedded.server.id")
- .doc("serverId for the embedded zookeeper server")
+ val ZK_DELETE_DATA_DIRECTORY_ON_CLOSE: ConfigEntry[Boolean] =
+ buildConf("zookeeper.embedded.delete-data-directory-on-close")
+ .doc("delete the storage directory of embedded zookeeper when service close")
.version("1.2.0")
Review comment:
1.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org