You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "yuxiqian (via GitHub)" <gi...@apache.org> on 2024/07/15 02:28:41 UTC

[PR] [FLINK-35072][doris] Support applying AlterColumnTypeEvent to Doris sink [flink-cdc]

yuxiqian opened a new pull request, #3473:
URL: https://github.com/apache/flink-cdc/pull/3473

   This closes FLINK-35072.
   
   Thanks to @qg-lin's great work, doris-flink-connector 1.6.2 has implemented column type modification API, so Flink CDC could implement this ticket more easily.
   
   Notice that this PR isn't ready for merge yet, since doris-flink-connector 1.6.2 artifact has not been released.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35072][doris] Support applying AlterColumnTypeEvent to Doris sink [flink-cdc]

Posted by "leonardBang (via GitHub)" <gi...@apache.org>.
leonardBang merged PR #3473:
URL: https://github.com/apache/flink-cdc/pull/3473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35072][doris] Support applying AlterColumnTypeEvent to Doris sink [flink-cdc]

Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on code in PR #3473:
URL: https://github.com/apache/flink-cdc/pull/3473#discussion_r1678766110


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/pom.xml:
##########
@@ -44,7 +44,7 @@ limitations under the License.
         <dependency>
             <groupId>org.apache.doris</groupId>
             <artifactId>flink-doris-connector-${flink.major.version}</artifactId>
-            <version>1.6.0</version>
+            <version>1.6.2</version>

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35072][doris] Support applying AlterColumnTypeEvent to Doris sink [flink-cdc]

Posted by "lvyanquan (via GitHub)" <gi...@apache.org>.
lvyanquan commented on PR #3473:
URL: https://github.com/apache/flink-cdc/pull/3473#issuecomment-2230069988

   LGTM. 
   But we seem to lack documentation describing what table schema changes we support, which could be added later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35072][doris] Support applying AlterColumnTypeEvent to Doris sink [flink-cdc]

Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on PR #3473:
URL: https://github.com/apache/flink-cdc/pull/3473#issuecomment-2229899392

   Flink doris connector 1.6.2 has been released, mark this ready for review. Could @qg-lin @lvyanquan please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35072][doris] Support applying AlterColumnTypeEvent to Doris sink [flink-cdc]

Posted by "qg-lin (via GitHub)" <gi...@apache.org>.
qg-lin commented on code in PR #3473:
URL: https://github.com/apache/flink-cdc/pull/3473#discussion_r1678727491


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-doris/pom.xml:
##########
@@ -44,7 +44,7 @@ limitations under the License.
         <dependency>
             <groupId>org.apache.doris</groupId>
             <artifactId>flink-doris-connector-${flink.major.version}</artifactId>
-            <version>1.6.0</version>
+            <version>1.6.2</version>

Review Comment:
   Could you control the version of dependencies via `properties` node?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-35072][doris] Support applying AlterColumnTypeEvent to Doris sink [flink-cdc]

Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on PR #3473:
URL: https://github.com/apache/flink-cdc/pull/3473#issuecomment-2230073960

   > LGTM. But we seem to lack documentation describing what table schema changes we supported in https://nightlies.apache.org/flink/flink-cdc-docs-release-3.1/docs/connectors/pipeline-connectors/doris, which could be added later.
   
   I'll open another PR for this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org