You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/02/26 17:53:02 UTC
[jira] [Commented] (AMBARI-24931) Bug at MetricsCollectorHAManager
class
[ https://issues.apache.org/jira/browse/AMBARI-24931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778281#comment-16778281 ]
Hudson commented on AMBARI-24931:
---------------------------------
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10471 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10471/])
AMBARI-24931. Bug at MetricsCollectorHAManager class. (mpapirkovskyy) (vishalsuvagia: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=55c82c713493ec2f72a7052e78888234015ac06b])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java
> Bug at MetricsCollectorHAManager class
> --------------------------------------
>
> Key: AMBARI-24931
> URL: https://issues.apache.org/jira/browse/AMBARI-24931
> Project: Ambari
> Issue Type: Bug
> Components: ambari-server
> Affects Versions: 2.8.0
> Reporter: Myroslav Papirkovskyi
> Assignee: Myroslav Papirkovskyi
> Priority: Critical
> Labels: pull-request-available
> Fix For: 2.8.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Here org/apache/ambari/server/controller/metrics/MetricsCollectorHAManager.java:80
> the second return statement is inside a loop without any condition. That breaks an execution flow
> {code:java}
> if (externalMetricCollectorsState.containsKey(clusterName)) {
> for (String externalCollectorHost : externalMetricCollectorsState.get(clusterName).keySet()) {
> if (externalMetricCollectorsState.get(clusterName).get(externalCollectorHost)) {
> return externalCollectorHost;
> }
> return refreshAndReturnRandomExternalCollectorHost(clusterName);
> }
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)