You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/08/27 18:28:33 UTC

[GitHub] [hbase] saintstack commented on a change in pull request #2321: HBASE-24958 CompactingMemStore.timeOfOldestEdit error update

saintstack commented on a change in pull request #2321:
URL: https://github.com/apache/hbase/pull/2321#discussion_r478614203



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/AbstractMemStore.java
##########
@@ -95,7 +96,10 @@ protected void resetActive() {
         memstoreAccounting.getHeapSize(), memstoreAccounting.getOffHeapSize(),
         memstoreAccounting.getCellsCount());
     }
-    timeOfOldestEdit = Long.MAX_VALUE;
+  }
+
+  protected void resetTimeOfOldestEdit() {
+    this.timeOfOldestEdit = Long.MAX_VALUE;

Review comment:
       Is Long.MAX_VALUE the initialized value? It gets changed when the next edit comes in?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org