You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/11/28 00:40:02 UTC
[GitHub] leakingoxide opened a new pull request #6452: [WiP] Add copy to
clipboard button in Explore view
leakingoxide opened a new pull request #6452: [WiP] Add copy to clipboard button in Explore view
URL: https://github.com/apache/incubator-superset/pull/6452
_I have to rethink variable names and probably handle data fetching errors in a more user-friendly way. But you're still encouraged to make any suggestions._
This is a first part of https://github.com/apache/incubator-superset/issues/6064.
It contains a functioning copy to clipboard button. You can try clicking it, and then pasting (as special! or ctrl+shift+v - for some reason google spreadsheets doesn't recognize \t character otherwise). I've also added a 4s promise, just so it'd be better visible during review phase how it behaves during data fetching. That promise will obviously be removed before merging.
Second part of that issue will involve downloading actual data from the server.
Preview:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org