You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/21 11:34:49 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #15253: [CI] Check Presto license files

lhotari opened a new pull request, #15253:
URL: https://github.com/apache/pulsar/pull/15253

   ### Motivation
   
   The new "Pulsar CI" workflow doesn't currently check Presto license files.
   The existing "build-and-license-check" builds only the core-modules profile because of performance reasons.
   
   ### Modifications
   
   Add license check to the step that builds the full apachepulsar/pulsar-test-latest-version:latest docker image.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #15253: [fix][CI] Check Pulsar SQL / Trino license files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #15253:
URL: https://github.com/apache/pulsar/pull/15253#issuecomment-1280606011

   @lhotari any progress here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15253: [CI] Check Presto license files

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15253:
URL: https://github.com/apache/pulsar/pull/15253#issuecomment-1134091568

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #15253: [fix][CI] Check Pulsar SQL / Trino license files

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15253:
URL: https://github.com/apache/pulsar/pull/15253#issuecomment-1250968469

   > I don't know if you did it on purpose but running this check also in the `Build and License check` step is a good thing because it can avoid unnecessary steps to be executed in case of failure
   
   It's intentionally not handled in "Build and License check". if it would be done there, we'd have to compile the whole distribution and that would mess up the whole "Build and License check" step. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #15253: [fix][CI] Check Pulsar SQL / Trino license files

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15253:
URL: https://github.com/apache/pulsar/pull/15253#issuecomment-1247642726

   @tisonkun Please review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15253: [fix][CI] Check Pulsar SQL / Trino license files

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15253:
URL: https://github.com/apache/pulsar/pull/15253#issuecomment-1247662454

   @lhotari Please provide a correct documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] github-actions[bot] commented on pull request #15253: [CI] Check Presto license files

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15253:
URL: https://github.com/apache/pulsar/pull/15253#issuecomment-1162547329

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- closed pull request #15253: [fix][CI] Check Pulsar SQL / Trino license files

Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #15253: [fix][CI] Check Pulsar SQL / Trino license files
URL: https://github.com/apache/pulsar/pull/15253


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] tisonkun commented on pull request #15253: [fix][CI] Check Pulsar SQL / Trino license files

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #15253:
URL: https://github.com/apache/pulsar/pull/15253#issuecomment-1288499673

   No responses. Try to supersede in #18171.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org