You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/25 15:50:44 UTC

[jira] [Commented] (FLINK-5776) Improve XXMapRunner support create instance by carrying constructor parameters

    [ https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15884288#comment-15884288 ] 

ASF GitHub Bot commented on FLINK-5776:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/3418

    [FLINK-5776][Table API & SQL]Improve XXMapRunner support create insta…

    …nce by carrying constructor parameters
    
    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [×] General
      - The pull request references the related JIRA issue ("[FLINK-5776] [Table API & SQL]Improve XXMapRunner support create instance by carrying constructor parameters")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [×] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-5776-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3418
    
----
commit 3339ef8d41643aafacf93b7cb9a2b86251e7b632
Author: 金竹 <ji...@alibaba-inc.com>
Date:   2017-02-21T03:35:35Z

    [FLINK-5776][Table API & SQL]Improve XXMapRunner support create instance by carrying constructor parameters

----


> Improve XXMapRunner support create instance by carrying constructor parameters
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-5776
>                 URL: https://issues.apache.org/jira/browse/FLINK-5776
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> At present, MapRunner FlatMapRunner only supports create non-parameter instance, but sometimes we need to carry constructor parameters to instantiate, so I would like to improve XXMapRunner support create instance by carrying constructor parameters.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)