You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Di Li <di...@ca.ibm.com> on 2017/04/24 12:41:27 UTC
Review Request 58665: AMBARI-20822 Ambari Agent needs to handle custom
version number like 1.2.3.4_Company in its Controller code
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/
-----------------------------------------------------------
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-20822
https://issues.apache.org/jira/browse/AMBARI-20822
Repository: ambari
Description
-------
Ambari agent printed the following error (albeit as a logger.info) during start up when its version is 1.2.3.0_MyAgent.
INFO 2017-04-21 06:17:19,510 Controller.py:545 - Exception in move_data_dir_mount_file(). Error: invalid literal for int() with base 10: '0_MyAgent'
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
ambari-agent/src/test/python/ambari_agent/TestController.py 7f5d451
Diff: https://reviews.apache.org/r/58665/diff/1/
Testing
-------
exiting unit tests, new unit test, patched a cluster with the fix and verify the error message message was gone.
Thanks,
Di Li
Re: Review Request 58665: AMBARI-20822 Ambari Agent needs to handle
custom version number like 1.2.3.4_Company in its Controller code
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/#review172840
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On April 24, 2017, 7:28 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58665/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 7:28 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20822
> https://issues.apache.org/jira/browse/AMBARI-20822
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari agent printed the following error (albeit as a logger.info) during start up when its version is 1.2.3.0_MyAgent.
> INFO 2017-04-21 06:17:19,510 Controller.py:545 - Exception in move_data_dir_mount_file(). Error: invalid literal for int() with base 10: '0_MyAgent'
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
> ambari-agent/src/test/python/ambari_agent/TestController.py 7f5d451
>
>
> Diff: https://reviews.apache.org/r/58665/diff/2/
>
>
> Testing
> -------
>
> exiting unit tests, new unit test, patched a cluster with the fix and verify the error message message was gone.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 58665: AMBARI-20822 Ambari Agent needs to handle
custom version number like 1.2.3.4_Company in its Controller code
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/#review172854
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 24, 2017, 7:28 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58665/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 7:28 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20822
> https://issues.apache.org/jira/browse/AMBARI-20822
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari agent printed the following error (albeit as a logger.info) during start up when its version is 1.2.3.0_MyAgent.
> INFO 2017-04-21 06:17:19,510 Controller.py:545 - Exception in move_data_dir_mount_file(). Error: invalid literal for int() with base 10: '0_MyAgent'
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
> ambari-agent/src/test/python/ambari_agent/TestController.py 7f5d451
>
>
> Diff: https://reviews.apache.org/r/58665/diff/2/
>
>
> Testing
> -------
>
> exiting unit tests, new unit test, patched a cluster with the fix and verify the error message message was gone.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 58665: AMBARI-20822 Ambari Agent needs to handle
custom version number like 1.2.3.4_Company in its Controller code
Posted by Di Li <di...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/
-----------------------------------------------------------
(Updated April 24, 2017, 7:28 p.m.)
Review request for Ambari and Tim Thorpe.
Bugs: AMBARI-20822
https://issues.apache.org/jira/browse/AMBARI-20822
Repository: ambari
Description
-------
Ambari agent printed the following error (albeit as a logger.info) during start up when its version is 1.2.3.0_MyAgent.
INFO 2017-04-21 06:17:19,510 Controller.py:545 - Exception in move_data_dir_mount_file(). Error: invalid literal for int() with base 10: '0_MyAgent'
Diffs (updated)
-----
ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
ambari-agent/src/test/python/ambari_agent/TestController.py 7f5d451
Diff: https://reviews.apache.org/r/58665/diff/2/
Changes: https://reviews.apache.org/r/58665/diff/1-2/
Testing
-------
exiting unit tests, new unit test, patched a cluster with the fix and verify the error message message was gone.
Thanks,
Di Li
Re: Review Request 58665: AMBARI-20822 Ambari Agent needs to handle
custom version number like 1.2.3.4_Company in its Controller code
Posted by Tim Thorpe <tt...@ca.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/#review172780
-----------------------------------------------------------
Ship it!
Ship It!
- Tim Thorpe
On April 24, 2017, 12:41 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58665/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 12:41 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20822
> https://issues.apache.org/jira/browse/AMBARI-20822
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari agent printed the following error (albeit as a logger.info) during start up when its version is 1.2.3.0_MyAgent.
> INFO 2017-04-21 06:17:19,510 Controller.py:545 - Exception in move_data_dir_mount_file(). Error: invalid literal for int() with base 10: '0_MyAgent'
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
> ambari-agent/src/test/python/ambari_agent/TestController.py 7f5d451
>
>
> Diff: https://reviews.apache.org/r/58665/diff/1/
>
>
> Testing
> -------
>
> exiting unit tests, new unit test, patched a cluster with the fix and verify the error message message was gone.
>
>
> Thanks,
>
> Di Li
>
>
Re: Review Request 58665: AMBARI-20822 Ambari Agent needs to handle
custom version number like 1.2.3.4_Company in its Controller code
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58665/#review172830
-----------------------------------------------------------
Fix it, then Ship it!
ambari-agent/src/main/python/ambari_agent/Controller.py
Lines 611 (patched)
<https://reviews.apache.org/r/58665/#comment245862>
This would fail with a version that contains more than 1 digit between dots.
Change to [\d+.]+
- Alejandro Fernandez
On April 24, 2017, 12:41 p.m., Di Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58665/
> -----------------------------------------------------------
>
> (Updated April 24, 2017, 12:41 p.m.)
>
>
> Review request for Ambari and Tim Thorpe.
>
>
> Bugs: AMBARI-20822
> https://issues.apache.org/jira/browse/AMBARI-20822
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari agent printed the following error (albeit as a logger.info) during start up when its version is 1.2.3.0_MyAgent.
> INFO 2017-04-21 06:17:19,510 Controller.py:545 - Exception in move_data_dir_mount_file(). Error: invalid literal for int() with base 10: '0_MyAgent'
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Controller.py 78b5c0c
> ambari-agent/src/test/python/ambari_agent/TestController.py 7f5d451
>
>
> Diff: https://reviews.apache.org/r/58665/diff/1/
>
>
> Testing
> -------
>
> exiting unit tests, new unit test, patched a cluster with the fix and verify the error message message was gone.
>
>
> Thanks,
>
> Di Li
>
>