You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2022/08/30 08:59:53 UTC
[GitHub] [unomi] dgriffon opened a new pull request, #484: UNOMI-653 : add missing properties to pageInfo schema
dgriffon opened a new pull request, #484:
URL: https://github.com/apache/unomi/pull/484
see https://issues.apache.org/jira/browse/UNOMI-653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan commented on a diff in pull request #484: UNOMI-653 : add missing properties to pageInfo schema
Posted by GitBox <gi...@apache.org>.
jkevan commented on code in PR #484:
URL: https://github.com/apache/unomi/pull/484#discussion_r958234808
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/items/page/page.properties.pageInfo.json:
##########
@@ -46,6 +46,14 @@
"type": ["null", "string"],
"format": "uri"
},
+ "referrerQuery": {
+ "type": ["null", "string"],
+ "format": "string"
Review Comment:
I dont think this format exists in json schema spec. Type "string" is enough anyway, there is no need for a specific format here.
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/items/page/page.properties.pageInfo.json:
##########
@@ -46,6 +46,14 @@
"type": ["null", "string"],
"format": "uri"
},
+ "referrerQuery": {
+ "type": ["null", "string"],
+ "format": "string"
+ },
+ "referrerHost": {
+ "type": ["null", "string"],
+ "format": "string"
Review Comment:
I dont think this format exists in json schema spec. Type "string" is enough anyway, there is no need for a specific format here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] dgriffon merged pull request #484: UNOMI-653 : add missing properties to pageInfo schema
Posted by GitBox <gi...@apache.org>.
dgriffon merged PR #484:
URL: https://github.com/apache/unomi/pull/484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] dgriffon commented on a diff in pull request #484: UNOMI-653 : add missing properties to pageInfo schema
Posted by GitBox <gi...@apache.org>.
dgriffon commented on code in PR #484:
URL: https://github.com/apache/unomi/pull/484#discussion_r958241998
##########
extensions/json-schema/services/src/main/resources/META-INF/cxs/schemas/items/page/page.properties.pageInfo.json:
##########
@@ -46,6 +46,14 @@
"type": ["null", "string"],
"format": "uri"
},
+ "referrerQuery": {
+ "type": ["null", "string"],
+ "format": "string"
Review Comment:
thank you for the advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@unomi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org