You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ignite.apache.org by Vasiliy Sisko <vs...@gridgain.com> on 2015/12/30 08:46:31 UTC

Incorrect setter method

Hello.

I found in IgniteConfiguration incorrectly named pair of getter and setter
methods:
Get method is: getMarshallerCacheThreadPoolSize
Set method is: setMarshallerCachePoolSize

I think we should to deprecate setMarshallerCachePoolSize method and create
new setMarshallerCacheThreadPoolSize method.

Thoughts?

-- 
Vasiliy Sisko
GridGain Systems
www.gridgain.com

Re: Incorrect setter method

Posted by Vasiliy Sisko <vs...@gridgain.com>.

Yes. I do.

On Wed, Dec 30, 2015 at 3:00 PM, Dmitriy Setrakyan <ds...@apache.org>
wrote:

> Agree. Vasiliy, can you do it (seems like a small fix) ?
>
> On Tue, Dec 29, 2015 at 11:46 PM, Vasiliy Sisko <vs...@gridgain.com>
> wrote:
>
> > Hello.
> >
> > I found in IgniteConfiguration incorrectly named pair of getter and
> setter
> > methods:
> > Get method is: getMarshallerCacheThreadPoolSize
> > Set method is: setMarshallerCachePoolSize
> >
> > I think we should to deprecate setMarshallerCachePoolSize method and
> create
> > new setMarshallerCacheThreadPoolSize method.
> >
> > Thoughts?
> >
> > --
> > Vasiliy Sisko
> > GridGain Systems
> > www.gridgain.com
> >
>



-- 
Vasiliy Sisko
GridGain Systems
www.gridgain.com

Re: Incorrect setter method

Posted by Dmitriy Setrakyan <ds...@apache.org>.

Agree. Vasiliy, can you do it (seems like a small fix) ?

On Tue, Dec 29, 2015 at 11:46 PM, Vasiliy Sisko <vs...@gridgain.com> wrote:

> Hello.
>
> I found in IgniteConfiguration incorrectly named pair of getter and setter
> methods:
> Get method is: getMarshallerCacheThreadPoolSize
> Set method is: setMarshallerCachePoolSize
>
> I think we should to deprecate setMarshallerCachePoolSize method and create
> new setMarshallerCacheThreadPoolSize method.
>
> Thoughts?
>
> --
> Vasiliy Sisko
> GridGain Systems
> www.gridgain.com
>