You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/02/18 13:15:49 UTC
[GitHub] [drill] vvysotskyi commented on a change in pull request #1987:
DRILL-7589: Set temporary tests folder for UDF_DIRECTORY_LOCAL,
fix allocators closing in BloomFilterTest,
fix permissions issue for TestGracefulShutdown tests
vvysotskyi commented on a change in pull request #1987: DRILL-7589: Set temporary tests folder for UDF_DIRECTORY_LOCAL, fix allocators closing in BloomFilterTest, fix permissions issue for TestGracefulShutdown tests
URL: https://github.com/apache/drill/pull/1987#discussion_r380650698
##########
File path: exec/java-exec/src/test/java/org/apache/drill/test/TestGracefulShutdown.java
##########
@@ -262,17 +265,15 @@ private boolean waitAndAssertDrillbitCount(ClusterFixture cluster, int zkRefresh
}
private static void setupFile(int file_num) throws Exception {
- final String file = "employee"+file_num+".json";
- final Path path = dirTestWatcher.getRootDir().toPath().resolve(file);
- try(PrintWriter out = new PrintWriter(new BufferedWriter(new FileWriter(path.toFile(), true)))) {
+ String file = "employee" + file_num + ".json";
+ Path path = dirTestWatcher.getRootDir().toPath().resolve(file);
+ try (PrintWriter out = new PrintWriter(new BufferedWriter(new FileWriter(path.toFile(), true)))) {
Review comment:
Looks like these lines are first 7 lines from `employee.json`. I have replaced it by reading its content.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services