[GitHub] [nuttx] xuxin930 commented on a diff in pull request #10614: qemu:fix ci error

["xuxin930 (via GitHub)" <gi...@apache.org>]

xuxin930 commented on code in PR #10614:
URL: https://github.com/apache/nuttx/pull/10614#discussion_r1325431692


##########
tools/ci/cibuild.sh:
##########
@@ -204,7 +204,23 @@ function elf-toolchain {
     esac
   fi
 
-  x86_64-elf-gcc --version
+  command x86_64-elf-gcc --version
+}
+
+function util-linux {

Review Comment:
   > a bit strange name used. I understand that it comes from ubuntu component, but anyway strange to read that Darwin target needs to install `util-linux`. Nit: Maybe we can rename this to `flock` or `flock-util`? Just brainstorming here
   
   i think `flock` function name will cause the following `if ! type flock` to related to bash function itself, resulting in an incorrect conditional result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org