You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/16 01:05:35 UTC

[GitHub] [incubator-nuttx] mkeydevelop opened a new pull request, #6628: sched/timer: timer_settime not fully satisfy IEEE 1003.1

mkeydevelop opened a new pull request, #6628:
URL: https://github.com/apache/incubator-nuttx/pull/6628

   ## Summary
   If the specified time has already passed, the function
   shall succeed and the expiration notification shall be made.
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6628: sched/timer: timer_settime not fully satisfy IEEE 1003.1

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6628:
URL: https://github.com/apache/incubator-nuttx/pull/6628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6628: sched/timer: timer_settime not fully satisfy IEEE 1003.1

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6628:
URL: https://github.com/apache/incubator-nuttx/pull/6628#discussion_r922674246


##########
sched/timer/timer_settime.c:
##########
@@ -306,18 +306,18 @@ int timer_settime(timer_t timerid, int flags,
       goto errout;
     }
 
-  /* If the time is in the past or now, then set up the next interval
-   * instead (assuming a repetitive timer).
+  /* If the specified time has already passed, the function shall succeed
+   * and the expiration notification shall be made.
    */
 
   if (delay <= 0)

Review Comment:
   ```suggestion
     if (delay < 0)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org