You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/06/06 03:21:32 UTC
Uploading patches for review
Hi,
Reviewing uploaded patches for few lines of change is easy. But when
the change is more it is hard to read, review is more time consuming and at
times you have to switch between the patch and eclipse to get more context.
Without the surrounding code it is also easy to miss things on review. Can
we make it a practice and decide on putting up the patches in review board
for review if it is slightly bigger? Commenting on the patch is also a
breeze in the review board.
Thoughts ???
Regards,
Rohini
Re: Uploading patches for review
Posted by Julien Le Dem <ju...@twitter.com>.
+1
On Wed, Jun 5, 2013 at 11:53 PM, Cheolsoo Park <pi...@gmail.com> wrote:
> I agree that we should use the RB more often.
>
>
> On Wed, Jun 5, 2013 at 6:50 PM, Jarek Jarcec Cecho <ja...@apache.org>wrote:
>
>> I can definitely recommend using the review board. We are using it already
>> in all other projects that I'm participating and it's really helping us out.
>>
>> Jarcec
>>
>> On Wed, Jun 05, 2013 at 06:21:32PM -0700, Rohini Palaniswamy wrote:
>> > Hi,
>> > Reviewing uploaded patches for few lines of change is easy. But when
>> > the change is more it is hard to read, review is more time consuming and
>> at
>> > times you have to switch between the patch and eclipse to get more
>> context.
>> > Without the surrounding code it is also easy to miss things on review.
>> Can
>> > we make it a practice and decide on putting up the patches in review
>> board
>> > for review if it is slightly bigger? Commenting on the patch is also a
>> > breeze in the review board.
>> >
>> > Thoughts ???
>> >
>> > Regards,
>> > Rohini
>>
Re: Uploading patches for review
Posted by Cheolsoo Park <pi...@gmail.com>.
I agree that we should use the RB more often.
On Wed, Jun 5, 2013 at 6:50 PM, Jarek Jarcec Cecho <ja...@apache.org>wrote:
> I can definitely recommend using the review board. We are using it already
> in all other projects that I'm participating and it's really helping us out.
>
> Jarcec
>
> On Wed, Jun 05, 2013 at 06:21:32PM -0700, Rohini Palaniswamy wrote:
> > Hi,
> > Reviewing uploaded patches for few lines of change is easy. But when
> > the change is more it is hard to read, review is more time consuming and
> at
> > times you have to switch between the patch and eclipse to get more
> context.
> > Without the surrounding code it is also easy to miss things on review.
> Can
> > we make it a practice and decide on putting up the patches in review
> board
> > for review if it is slightly bigger? Commenting on the patch is also a
> > breeze in the review board.
> >
> > Thoughts ???
> >
> > Regards,
> > Rohini
>
Re: Uploading patches for review
Posted by Jarek Jarcec Cecho <ja...@apache.org>.
I can definitely recommend using the review board. We are using it already in all other projects that I'm participating and it's really helping us out.
Jarcec
On Wed, Jun 05, 2013 at 06:21:32PM -0700, Rohini Palaniswamy wrote:
> Hi,
> Reviewing uploaded patches for few lines of change is easy. But when
> the change is more it is hard to read, review is more time consuming and at
> times you have to switch between the patch and eclipse to get more context.
> Without the surrounding code it is also easy to miss things on review. Can
> we make it a practice and decide on putting up the patches in review board
> for review if it is slightly bigger? Commenting on the patch is also a
> breeze in the review board.
>
> Thoughts ???
>
> Regards,
> Rohini
Re: Uploading patches for review
Posted by Alan Gates <ga...@hortonworks.com>.
I think it's fine for a reviewer to ask for a particular patch to be put in review board. I think it would also be fine to put in our HowToContribute doc that for larger patches putting it in review board may help get it reviewed more quickly. I'm not in favor of requiring it, as some reviewers don't use review board.
Alan.
On Jun 6, 2013, at 2:21 AM, Rohini Palaniswamy wrote:
> Hi,
> Reviewing uploaded patches for few lines of change is easy. But when
> the change is more it is hard to read, review is more time consuming and at
> times you have to switch between the patch and eclipse to get more context.
> Without the surrounding code it is also easy to miss things on review. Can
> we make it a practice and decide on putting up the patches in review board
> for review if it is slightly bigger? Commenting on the patch is also a
> breeze in the review board.
>
> Thoughts ???
>
> Regards,
> Rohini