Re: [PR] [#2061]fix(server): Fix netty memory leak when removeBuffer and cacheShuffle… [incubator-uniffle]

["zhengchenyu (via GitHub)" <gi...@apache.org>]

zhengchenyu commented on code in PR #2059:
URL: https://github.com/apache/incubator-uniffle/pull/2059#discussion_r1772741677


##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBufferWithLinkedList.java:
##########
@@ -110,7 +111,8 @@ public int getBlockCount() {
   }
 
   @Override
-  public void release() {
+  public synchronized void release() {

Review Comment:
   I think close is more appropriate than release. The close means that we has closed this and cannot be used again. Release just means that we releases the resource.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org