You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/03/24 13:09:08 UTC

[GitHub] [avro] zcsizmadia opened a new pull request #1621: AVRO-3469: Add .NET 7.0 prerelease support

zcsizmadia opened a new pull request #1621:
URL: https://github.com/apache/avro/pull/1621


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g commented on a change in pull request #1621: AVRO-3469: Add .NET 7.0 prerelease support

Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1621:
URL: https://github.com/apache/avro/pull/1621#discussion_r834344734



##########
File path: .github/workflows/test-lang-csharp.yml
##########
@@ -63,6 +63,19 @@ jobs:
       - name: Test
         run: ./build.sh test
 
+      # Build and test against .NET 7
+      # .NET 7 is not released yet, however this is a good way to test if the project is ready for the release
+      # Once .NET 7 is officially released, this can be removed and 7.0.x can be used instead above
+      - name: Install .NET SDK 7.0 (pre-release)
+        uses: actions/setup-dotnet@v1
+        with:
+          include-prerelease: true
+          dotnet-version: |

Review comment:
       How does this work now ?!
   For Java SDK we use the `matrix`. Here at lines 49-51 I see that 3.x, 5.x and 6.x are installed in one step. Then at line 64 the tests are executed. How do they know which .NET version to use ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g merged pull request #1621: AVRO-3469: Add .NET 7.0 prerelease support

Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1621:
URL: https://github.com/apache/avro/pull/1621


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] zcsizmadia commented on a change in pull request #1621: AVRO-3469: Add .NET 7.0 prerelease support

Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on a change in pull request #1621:
URL: https://github.com/apache/avro/pull/1621#discussion_r834374598



##########
File path: .github/workflows/test-lang-csharp.yml
##########
@@ -63,6 +63,19 @@ jobs:
       - name: Test
         run: ./build.sh test
 
+      # Build and test against .NET 7
+      # .NET 7 is not released yet, however this is a good way to test if the project is ready for the release
+      # Once .NET 7 is officially released, this can be removed and 7.0.x can be used instead above
+      - name: Install .NET SDK 7.0 (pre-release)
+        uses: actions/setup-dotnet@v1
+        with:
+          include-prerelease: true
+          dotnet-version: |

Review comment:
       In c# we generate a nupkg which has all the supported  .NET SDK version compiled. Currently netcoreapp3.1, net5.0, net6.0, which are the MS officially supported versions. This is defined in `common.props` by the `DefaultExeTargetFrameworks` prop. So the matric approach does not work, because all the supported SDKs must be installed in the building/testing image and not just one specific version. If the nupkg would be only netstandard we could get away with one specific version, however avrogen tool must be compiled for all available versions. When that tool is installed, the matching framework SDK version is selected from the nupkg.
   E.g. This is the reason I am eager for the 1.11.1 version, because until now, I cannot use avrogen in purely/only .NET 6 SDK environment.
   
   So the build step is the same, however when the normal build is done, I install .NET SDK and build/test only for net7.0 to check if all is good.
   
   Just fyi, once NEt 7 is released, `DefaultExeTargetFrameworks` will be `netcoreapp3.1;net6.0;net7.0` which will reflect the EOL status of the dotnet SDKs (https://dotnet.microsoft.com/en-us/download/dotnet)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [avro] martin-g commented on a change in pull request #1621: AVRO-3469: Add .NET 7.0 prerelease support

Posted by GitBox <gi...@apache.org>.
martin-g commented on a change in pull request #1621:
URL: https://github.com/apache/avro/pull/1621#discussion_r834344734



##########
File path: .github/workflows/test-lang-csharp.yml
##########
@@ -63,6 +63,19 @@ jobs:
       - name: Test
         run: ./build.sh test
 
+      # Build and test against .NET 7
+      # .NET 7 is not released yet, however this is a good way to test if the project is ready for the release
+      # Once .NET 7 is officially released, this can be removed and 7.0.x can be used instead above
+      - name: Install .NET SDK 7.0 (pre-release)
+        uses: actions/setup-dotnet@v1
+        with:
+          include-prerelease: true
+          dotnet-version: |

Review comment:
       How does this work now ?!
   For Java SDK we use the `matrix`, so there are N executions of the job. Here at lines 49-51 I see that 3.x, 5.x and 6.x are installed in one step. Then at line 64 the tests are executed. How do they know which .NET version to use in the single job?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org