You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/11/08 01:14:50 UTC
[GitHub] [incubator-gobblin] Will-Lo opened a new pull request #3151: [GOBBLIN-1313] Create Github Action to automatically build and publish images
Will-Lo opened a new pull request #3151:
URL: https://github.com/apache/incubator-gobblin/pull/3151
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1313
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Utilizes Github Actions to push docker images to Github Container Repository. It tags images by their hash, branch (but only builds on master so it will only track master for now) and latest for the most recent image.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3151: [GOBBLIN-1313] Create Github Action to automatically build and publish images
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3151:
URL: https://github.com/apache/incubator-gobblin/pull/3151#issuecomment-723519511
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=h1) Report
> Merging [#3151](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=desc) (c7b16eb) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/64c8ad93c239b76968ecd644a55f5d0b1c4fc400?el=desc) (64c8ad9) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3151 +/- ##
============================================
- Coverage 46.01% 46.00% -0.01%
Complexity 9592 9592
============================================
Files 1989 1989
Lines 75901 75901
Branches 8452 8452
============================================
- Hits 34923 34922 -1
- Misses 37710 37712 +2
+ Partials 3268 3267 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70.00% <0.00%> (-2.23%)` | `13.00% <0.00%> (ø%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0.00%> (+1.42%)` | `4.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=footer). Last update [64c8ad9...c7b16eb](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io commented on pull request #3151: [GOBBLIN-1313] Create Github Action to automatically build and publish images
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #3151:
URL: https://github.com/apache/incubator-gobblin/pull/3151#issuecomment-723519511
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=h1) Report
> Merging [#3151](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=desc) (c7b16eb) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/64c8ad93c239b76968ecd644a55f5d0b1c4fc400?el=desc) (64c8ad9) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3151 +/- ##
============================================
- Coverage 46.01% 46.00% -0.01%
Complexity 9592 9592
============================================
Files 1989 1989
Lines 75901 75901
Branches 8452 8452
============================================
- Hits 34923 34922 -1
- Misses 37710 37712 +2
+ Partials 3268 3267 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=) | `70.00% <0.00%> (-2.23%)` | `13.00% <0.00%> (ø%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0.00%> (+1.42%)` | `4.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=footer). Last update [64c8ad9...c7b16eb](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-io edited a comment on pull request #3151: [GOBBLIN-1313] Create Github Action to automatically build and publish images
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #3151:
URL: https://github.com/apache/incubator-gobblin/pull/3151#issuecomment-723519511
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=h1) Report
> Merging [#3151](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=desc) (c7b16eb) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/64c8ad93c239b76968ecd644a55f5d0b1c4fc400?el=desc) (64c8ad9) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3151 +/- ##
============================================
+ Coverage 46.01% 46.03% +0.02%
- Complexity 9592 9617 +25
============================================
Files 1989 1993 +4
Lines 75901 76177 +276
Branches 8452 8502 +50
============================================
+ Hits 34923 35067 +144
- Misses 37710 37842 +132
Partials 3268 3268
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../java/org/apache/gobblin/runtime/api/FlowSpec.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0Zsb3dTcGVjLmphdmE=) | `42.07% <0.00%> (-1.43%)` | `13.00% <0.00%> (ø%)` | |
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ice/LocalGroupOwnershipPathAlterationListener.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Mb2NhbEdyb3VwT3duZXJzaGlwUGF0aEFsdGVyYXRpb25MaXN0ZW5lci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...he/gobblin/service/LocalGroupOwnershipService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Mb2NhbEdyb3VwT3duZXJzaGlwU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...che/gobblin/service/NoopGroupOwnershipService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Ob29wR3JvdXBPd25lcnNoaXBTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../apache/gobblin/service/GroupOwnershipService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9Hcm91cE93bmVyc2hpcFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh) | `62.85% <0.00%> (+1.42%)` | `4.00% <0.00%> (ø%)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `62.36% <0.00%> (+2.15%)` | `6.00% <0.00%> (ø%)` | |
| [...che/gobblin/runtime/spec\_store/MysqlSpecStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc3BlY19zdG9yZS9NeXNxbFNwZWNTdG9yZS5qYXZh) | `68.10% <0.00%> (+2.72%)` | `30.00% <0.00%> (+2.00%)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3151/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=footer). Last update [64c8ad9...9e61dab](https://codecov.io/gh/apache/incubator-gobblin/pull/3151?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] Will-Lo commented on pull request #3151: [GOBBLIN-1313] Create Github Action to automatically build and publish images
Posted by GitBox <gi...@apache.org>.
Will-Lo commented on pull request #3151:
URL: https://github.com/apache/incubator-gobblin/pull/3151#issuecomment-723517400
@shirshanka @autumnust
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] shirshanka commented on pull request #3151: [GOBBLIN-1313] Create Github Action to automatically build and publish images
Posted by GitBox <gi...@apache.org>.
shirshanka commented on pull request #3151:
URL: https://github.com/apache/incubator-gobblin/pull/3151#issuecomment-735447232
@Will-Lo : could you update this PR with the env variables from https://issues.apache.org/jira/browse/INFRA-21119
Specifically I think we just need to change DOCKERHUB_USERNAME to DOCKERHUB_USER
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3151: [GOBBLIN-1313] Create Github Action to automatically build and publish images
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3151:
URL: https://github.com/apache/incubator-gobblin/pull/3151
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org