You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Steve Loughran <st...@apache.org> on 2010/01/20 15:56:39 UTC
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Having just checked this in, I was struck by a thought of guilt: should
I have done this given we are in the RC phase? I'm just looking at what
(minor) changes I have in my local ant build (this & some better error
and OOM handling in the junit result formatters). I've stuck this in,
but technically it's still a code change, right?
I can move this patch to a branch instead.
-steve
stevel@apache.org wrote:
> Author: stevel
> Date: Wed Jan 20 14:41:43 2010
> New Revision: 901218
>
> URL: http://svn.apache.org/viewvc?rev=901218&view=rev
> Log:
> <scp> task didn't report build file location when a remote operation failed
> Bugzilla Report 48578.
>
> Modified:
> ant/core/trunk/WHATSNEW
> ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
>
> Modified: ant/core/trunk/WHATSNEW
> URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=901218&r1=901217&r2=901218&view=diff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Posted by Matt Benson <gu...@gmail.com>.
Finally got to this; sorry for the delay.
-Matt
On Jan 21, 2010, at 12:56 PM, Antoine Levy Lambert wrote:
> Matt,
>
> I think it is OK to address that. As long as the change does not
> introduce compability problems.
>
> Regards,
>
> Antoine
>
> Matt Benson wrote:
>> In particular, PresentSelector and MappingSelector don't allow
>> typed FileNameMapper implementations, so it's rather difficult to
>> set up e.g. Chained/Composite or custom mappers; you have to
>> declare the mapper separately and ref it. I wouldn't call it a
>> bug, but I would call it an incomplete API. Your call, Antoine.
>>
>> -Matt
>>
>> On Jan 20, 2010, at 10:06 AM, Antoine Levy Lambert wrote:
>>
>>> I think it is OK to commit bug fixes, but not OK to introduce new
>>> concepts.
>>>
>>> Just my 2cents.
>>>
>>> Antoine
>>>
>>> Matt Benson wrote:
>>>> I also have a few quite minor things, so am interested in the
>>>> community opinion here.
>>>>
>>>> On Jan 20, 2010, at 8:56 AM, Steve Loughran wrote:
>>>>
>>>>>
>>>>> Having just checked this in, I was struck by a thought of
>>>>> guilt: should I have done this given we are in the RC phase?
>>>>> I'm just looking at what (minor) changes I have in my local ant
>>>>> build (this & some better error and OOM handling in the junit
>>>>> result formatters). I've stuck this in, but technically it's
>>>>> still a code change, right?
>>>>>
>>>>> I can move this patch to a branch instead.
>>>>>
>>>>> -steve
>>>>>
>>>>> stevel@apache.org wrote:
>>>>>> Author: stevel
>>>>>> Date: Wed Jan 20 14:41:43 2010
>>>>>> New Revision: 901218
>>>>>> URL: http://svn.apache.org/viewvc?rev=901218&view=rev
>>>>>> Log:
>>>>>> <scp> task didn't report build file location when a remote
>>>>>> operation failed
>>>>>> Bugzilla Report 48578.
>>>>>> Modified:
>>>>>> ant/core/trunk/WHATSNEW
>>>>>> ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/
>>>>>> optional/ssh/Scp.java
>>>>>> Modified: ant/core/trunk/WHATSNEW
>>>>>> URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?
>>>>>> rev=901218&r1=901217&r2=901218&view=diff
>>>>>
>>>>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Posted by Antoine Levy Lambert <an...@gmx.de>.
Matt,
I think it is OK to address that. As long as the change does not
introduce compability problems.
Regards,
Antoine
Matt Benson wrote:
> In particular, PresentSelector and MappingSelector don't allow typed
> FileNameMapper implementations, so it's rather difficult to set up
> e.g. Chained/Composite or custom mappers; you have to declare the
> mapper separately and ref it. I wouldn't call it a bug, but I would
> call it an incomplete API. Your call, Antoine.
>
> -Matt
>
> On Jan 20, 2010, at 10:06 AM, Antoine Levy Lambert wrote:
>
>> I think it is OK to commit bug fixes, but not OK to introduce new
>> concepts.
>>
>> Just my 2cents.
>>
>> Antoine
>>
>> Matt Benson wrote:
>>> I also have a few quite minor things, so am interested in the
>>> community opinion here.
>>>
>>> On Jan 20, 2010, at 8:56 AM, Steve Loughran wrote:
>>>
>>>>
>>>> Having just checked this in, I was struck by a thought of guilt:
>>>> should I have done this given we are in the RC phase? I'm just
>>>> looking at what (minor) changes I have in my local ant build (this
>>>> & some better error and OOM handling in the junit result
>>>> formatters). I've stuck this in, but technically it's still a code
>>>> change, right?
>>>>
>>>> I can move this patch to a branch instead.
>>>>
>>>> -steve
>>>>
>>>> stevel@apache.org wrote:
>>>>> Author: stevel
>>>>> Date: Wed Jan 20 14:41:43 2010
>>>>> New Revision: 901218
>>>>> URL: http://svn.apache.org/viewvc?rev=901218&view=rev
>>>>> Log:
>>>>> <scp> task didn't report build file location when a remote
>>>>> operation failed
>>>>> Bugzilla Report 48578.
>>>>> Modified:
>>>>> ant/core/trunk/WHATSNEW
>>>>>
>>>>> ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
>>>>>
>>>>> Modified: ant/core/trunk/WHATSNEW
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=901218&r1=901217&r2=901218&view=diff
>>>>>
>>>>
>>>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Posted by Matt Benson <gu...@gmail.com>.
In particular, PresentSelector and MappingSelector don't allow typed
FileNameMapper implementations, so it's rather difficult to set up
e.g. Chained/Composite or custom mappers; you have to declare the
mapper separately and ref it. I wouldn't call it a bug, but I would
call it an incomplete API. Your call, Antoine.
-Matt
On Jan 20, 2010, at 10:06 AM, Antoine Levy Lambert wrote:
> I think it is OK to commit bug fixes, but not OK to introduce new
> concepts.
>
> Just my 2cents.
>
> Antoine
>
> Matt Benson wrote:
>> I also have a few quite minor things, so am interested in the
>> community opinion here.
>>
>> On Jan 20, 2010, at 8:56 AM, Steve Loughran wrote:
>>
>>>
>>> Having just checked this in, I was struck by a thought of guilt:
>>> should I have done this given we are in the RC phase? I'm just
>>> looking at what (minor) changes I have in my local ant build
>>> (this & some better error and OOM handling in the junit result
>>> formatters). I've stuck this in, but technically it's still a
>>> code change, right?
>>>
>>> I can move this patch to a branch instead.
>>>
>>> -steve
>>>
>>> stevel@apache.org wrote:
>>>> Author: stevel
>>>> Date: Wed Jan 20 14:41:43 2010
>>>> New Revision: 901218
>>>> URL: http://svn.apache.org/viewvc?rev=901218&view=rev
>>>> Log:
>>>> <scp> task didn't report build file location when a remote
>>>> operation failed
>>>> Bugzilla Report 48578.
>>>> Modified:
>>>> ant/core/trunk/WHATSNEW
>>>> ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/
>>>> optional/ssh/Scp.java
>>>> Modified: ant/core/trunk/WHATSNEW
>>>> URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?
>>>> rev=901218&r1=901217&r2=901218&view=diff
>>>
>>>
>>>
>>>
>>> --------------------------------------------------------------------
>>> -
>>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>>> For additional commands, e-mail: dev-help@ant.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Posted by Steve Loughran <st...@apache.org>.
Antoine Levy Lambert wrote:
> I think it is OK to commit bug fixes, but not OK to introduce new concepts.
>
> Just my 2cents.
OK. I'll leave out the junit stuff as they are trying to be more robust
against OOM errors, and they are trickier to test that they actually
work without causing damage
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Posted by Antoine Levy Lambert <an...@gmx.de>.
I think it is OK to commit bug fixes, but not OK to introduce new concepts.
Just my 2cents.
Antoine
Matt Benson wrote:
> I also have a few quite minor things, so am interested in the
> community opinion here.
>
> On Jan 20, 2010, at 8:56 AM, Steve Loughran wrote:
>
>>
>> Having just checked this in, I was struck by a thought of guilt:
>> should I have done this given we are in the RC phase? I'm just
>> looking at what (minor) changes I have in my local ant build (this &
>> some better error and OOM handling in the junit result formatters).
>> I've stuck this in, but technically it's still a code change, right?
>>
>> I can move this patch to a branch instead.
>>
>> -steve
>>
>> stevel@apache.org wrote:
>>> Author: stevel
>>> Date: Wed Jan 20 14:41:43 2010
>>> New Revision: 901218
>>> URL: http://svn.apache.org/viewvc?rev=901218&view=rev
>>> Log:
>>> <scp> task didn't report build file location when a remote operation
>>> failed
>>> Bugzilla Report 48578.
>>> Modified:
>>> ant/core/trunk/WHATSNEW
>>>
>>> ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
>>>
>>> Modified: ant/core/trunk/WHATSNEW
>>> URL:
>>> http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?rev=901218&r1=901217&r2=901218&view=diff
>>>
>>
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
>> For additional commands, e-mail: dev-help@ant.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Posted by Stefan Bodewig <bo...@apache.org>.
On 2010-01-20, Matt Benson <gu...@gmail.com> wrote:
> On Jan 20, 2010, at 8:56 AM, Steve Loughran wrote:
>> I'm just looking at what (minor) changes I have in my local ant build
>> (this & some better error and OOM handling in the junit result
>> formatters). I've stuck this in, but technically it's still a code
>> change, right?
> I also have a few quite minor things, so am interested in the
> community opinion here.
I trust your judgement. If you consider the changes minor, go ahead and
apply them.
Stefan
On a related note: One of the more recent Bugzilla Report points to
problems with the new LayoutPreservingProperties class that may even
take a tiny bit more than minor changes to fix. The first AntUnit tests
I wrote failed because the new code seems to add extra linefeeds or
every line - will check again later this week.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: svn commit: r901218 - in /ant/core/trunk: WHATSNEW src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java
Posted by Matt Benson <gu...@gmail.com>.
I also have a few quite minor things, so am interested in the
community opinion here.
On Jan 20, 2010, at 8:56 AM, Steve Loughran wrote:
>
> Having just checked this in, I was struck by a thought of guilt:
> should I have done this given we are in the RC phase? I'm just
> looking at what (minor) changes I have in my local ant build (this
> & some better error and OOM handling in the junit result
> formatters). I've stuck this in, but technically it's still a code
> change, right?
>
> I can move this patch to a branch instead.
>
> -steve
>
> stevel@apache.org wrote:
>> Author: stevel
>> Date: Wed Jan 20 14:41:43 2010
>> New Revision: 901218
>> URL: http://svn.apache.org/viewvc?rev=901218&view=rev
>> Log:
>> <scp> task didn't report build file location when a remote
>> operation failed
>> Bugzilla Report 48578.
>> Modified:
>> ant/core/trunk/WHATSNEW
>> ant/core/trunk/src/main/org/apache/tools/ant/taskdefs/optional/
>> ssh/Scp.java
>> Modified: ant/core/trunk/WHATSNEW
>> URL: http://svn.apache.org/viewvc/ant/core/trunk/WHATSNEW?
>> rev=901218&r1=901217&r2=901218&view=diff
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org