You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/05/21 06:10:30 UTC

[GitHub] [apisix-ingress-controller] Donghui0 opened a new pull request #477: fix: ingress_class configuration invalid(#475)

Donghui0 opened a new pull request #477:
URL: https://github.com/apache/apisix-ingress-controller/pull/477


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [√] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   - Related issues
   #475 
   ___
   ### Bugfix
   - Description
   ingress_class configuration is invalid
   - How to fix?
   we should use controller.config.Kubernetes.IngressClass  instead config.ingressClass
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #477: fix: ingress_class configuration invalid(#475)

Posted by GitBox <gi...@apache.org>.
gxthrj merged pull request #477:
URL: https://github.com/apache/apisix-ingress-controller/pull/477


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on pull request #477: fix: ingress_class configuration invalid(#475)

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #477:
URL: https://github.com/apache/apisix-ingress-controller/pull/477#issuecomment-846990215


   @Donghui0 The unit test cases should be adjusted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org