[GitHub] dlg99 commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth

[gi...@git.apache.org]

dlg99 commented on a change in pull request #229: Issue 228: BookKeeper Server: Index Page Management Memory Growth
URL: https://github.com/apache/bookkeeper/pull/229#discussion_r128062624
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexInMemPageMgr.java
 ##########
 @@ -51,14 +60,20 @@
 
     private static class InMemPageCollection implements LEPStateChangeCallback {
 
-        ConcurrentMap<Long, ConcurrentMap<Long,LedgerEntryPage>> pages;
+        final ConcurrentMap<Long, ConcurrentMap<Long,LedgerEntryPage>> pages;
+        final Map<EntryKey, LedgerEntryPage> lruCleanPageMap;
+        final ConcurrentLinkedQueue<LedgerEntryPage> listOfFreePages;
 
 Review comment:
   Just curious, why custom object pool vs i.e. apache commons pool?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services