You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/23 09:52:26 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #14368: Use latest Pip version when building image.

potiuk commented on a change in pull request #14368:
URL: https://github.com/apache/airflow/pull/14368#discussion_r580898233



##########
File path: Dockerfile
##########
@@ -190,7 +190,7 @@ ENV AIRFLOW_INSTALL_USER_FLAG="--user"
 ENV AIRFLOW_INSTALL_EDITABLE_FLAG=""
 
 # Upgrade to specific PIP version
-RUN pip install --upgrade "pip==${AIRFLOW_PIP_VERSION}"
+RUN pip install --upgrade "pip~=${AIRFLOW_PIP_VERSION}"

Review comment:
       Well that what I actually intended :) ~= is defined as "compatible" release (at least that's the name PIP definition uses) - and I think this makes sense to always increment patchlevel automatically but then make a deliberate decisions about major level increases (looking at PIP history this is a reasonable) - even if it means that only new features are added. 
   
   So in short `>=21.0.1, ==21.0.*` is exactly what I wanted to achieve.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org