[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42149: [SPARK-44509][CONNECT][FOLLOW-UP] Add inheritable support in new job cancellation API

["HyukjinKwon (via GitHub)" <gi...@apache.org>]

HyukjinKwon commented on code in PR #42149:
URL: https://github.com/apache/spark/pull/42149#discussion_r1273124452


##########
python/pyspark/util.py:
##########
@@ -348,56 +373,87 @@ def wrapped(*args: Any, **kwargs: Any) -> Any:
 
 class InheritableThread(threading.Thread):
     """
-    Thread that is recommended to be used in PySpark instead of :class:`threading.Thread`
-    when the pinned thread mode is enabled. The usage of this class is exactly same as
-    :class:`threading.Thread` but correctly inherits the inheritable properties specific
-    to JVM thread such as ``InheritableThreadLocal``.
-
-    Also, note that pinned thread mode does not close the connection from Python

Review Comment:
   This is already fixed in Py4J, https://github.com/py4j/py4j/pull/471



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org