You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/08/14 19:13:08 UTC
[GitHub] [hadoop] zhengbli opened a new pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
zhengbli opened a new pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#issuecomment-674297198
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 28m 47s | trunk passed |
| +1 :green_heart: | compile | 0m 57s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 0m 51s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 0m 42s | trunk passed |
| +1 :green_heart: | mvnsite | 0m 55s | trunk passed |
| +1 :green_heart: | shadedclient | 15m 34s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 40s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 0m 37s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 1m 43s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 41s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 48s | the patch passed |
| +1 :green_heart: | compile | 0m 49s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javac | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 43s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | javac | 0m 43s | the patch passed |
| -0 :warning: | checkstyle | 0m 31s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 15 new + 2 unchanged - 2 fixed = 17 total (was 4) |
| +1 :green_heart: | mvnsite | 0m 45s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 14m 14s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 32s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 0m 32s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | findbugs | 1m 46s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 94m 27s | hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate ASF License warnings. |
| | | 168m 33s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.server.resourcemanager.reservation.TestCapacityOverTimePolicy |
| | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2228 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux c16aad18a6c4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / b93dd7c281c |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/1/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/1/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/1/testReport/ |
| Max. process+thread count | 868 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/1/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri commented on pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
goiri commented on pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#issuecomment-676551458
@BilwaST do you have further comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri commented on a change in pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
goiri commented on a change in pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#discussion_r470821977
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/distributed/NodeQueueLoadMonitor.java
##########
@@ -260,55 +236,72 @@ public void updateNode(RMNode rmNode) {
opportunisticContainersStatus =
OpportunisticContainersStatus.newInstance();
}
- int opportQueueCapacity =
- opportunisticContainersStatus.getOpportQueueCapacity();
- int estimatedQueueWaitTime =
- opportunisticContainersStatus.getEstimatedQueueWaitTime();
- int waitQueueLength = opportunisticContainersStatus.getWaitQueueLength();
+
// Add nodes to clusterNodes. If estimatedQueueTime is -1, ignore node
// UNLESS comparator is based on queue length.
ReentrantReadWriteLock.WriteLock writeLock = clusterNodesLock.writeLock();
writeLock.lock();
try {
- ClusterNode currentNode = this.clusterNodes.get(rmNode.getNodeID());
- if (currentNode == null) {
- if (rmNode.getState() != NodeState.DECOMMISSIONING &&
- (estimatedQueueWaitTime != -1 ||
- comparator == LoadComparator.QUEUE_LENGTH)) {
- this.clusterNodes.put(rmNode.getNodeID(),
- new ClusterNode(rmNode.getNodeID())
- .setQueueWaitTime(estimatedQueueWaitTime)
- .setQueueLength(waitQueueLength)
- .setQueueCapacity(opportQueueCapacity));
- LOG.info("Inserting ClusterNode [" + rmNode.getNodeID() + "] " +
- "with queue wait time [" + estimatedQueueWaitTime + "] and " +
- "wait queue length [" + waitQueueLength + "]");
- } else {
- LOG.warn("IGNORING ClusterNode [" + rmNode.getNodeID() + "] " +
- "with queue wait time [" + estimatedQueueWaitTime + "] and " +
- "wait queue length [" + waitQueueLength + "]");
- }
+ ClusterNode clusterNode = this.clusterNodes.get(rmNode.getNodeID());
+ if (clusterNode == null) {
+ onNewNodeAdded(rmNode, opportunisticContainersStatus);
} else {
- if (rmNode.getState() != NodeState.DECOMMISSIONING &&
- (estimatedQueueWaitTime != -1 ||
- comparator == LoadComparator.QUEUE_LENGTH)) {
- currentNode
+ onExistingNodeUpdated(rmNode, clusterNode, opportunisticContainersStatus);
+ }
+ } finally {
+ writeLock.unlock();
+ }
+ }
+
+ protected void onNewNodeAdded(
+ RMNode rmNode, OpportunisticContainersStatus status) {
+ int opportQueueCapacity = status.getOpportQueueCapacity();
+ int estimatedQueueWaitTime = status.getEstimatedQueueWaitTime();
+ int waitQueueLength = status.getWaitQueueLength();
+
+ if (rmNode.getState() != NodeState.DECOMMISSIONING &&
+ (estimatedQueueWaitTime != -1 ||
+ comparator == LoadComparator.QUEUE_LENGTH)) {
+ this.clusterNodes.put(rmNode.getNodeID(),
+ new ClusterNode(rmNode.getNodeID())
.setQueueWaitTime(estimatedQueueWaitTime)
.setQueueLength(waitQueueLength)
- .updateTimestamp();
- LOG.debug("Updating ClusterNode [{}] with queue wait time [{}] and"
+ .setNodeLabels(rmNode.getNodeLabels())
+ .setQueueCapacity(opportQueueCapacity));
+ LOG.info("Inserting ClusterNode [" + rmNode.getNodeID() + "] " +
Review comment:
As we are moving this, we can make it a proper logger comment with {}.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] zhengbli commented on a change in pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
zhengbli commented on a change in pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#discussion_r470829324
##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/distributed/NodeQueueLoadMonitor.java
##########
@@ -260,55 +236,72 @@ public void updateNode(RMNode rmNode) {
opportunisticContainersStatus =
OpportunisticContainersStatus.newInstance();
}
- int opportQueueCapacity =
- opportunisticContainersStatus.getOpportQueueCapacity();
- int estimatedQueueWaitTime =
- opportunisticContainersStatus.getEstimatedQueueWaitTime();
- int waitQueueLength = opportunisticContainersStatus.getWaitQueueLength();
+
// Add nodes to clusterNodes. If estimatedQueueTime is -1, ignore node
// UNLESS comparator is based on queue length.
ReentrantReadWriteLock.WriteLock writeLock = clusterNodesLock.writeLock();
writeLock.lock();
try {
- ClusterNode currentNode = this.clusterNodes.get(rmNode.getNodeID());
- if (currentNode == null) {
- if (rmNode.getState() != NodeState.DECOMMISSIONING &&
- (estimatedQueueWaitTime != -1 ||
- comparator == LoadComparator.QUEUE_LENGTH)) {
- this.clusterNodes.put(rmNode.getNodeID(),
- new ClusterNode(rmNode.getNodeID())
- .setQueueWaitTime(estimatedQueueWaitTime)
- .setQueueLength(waitQueueLength)
- .setQueueCapacity(opportQueueCapacity));
- LOG.info("Inserting ClusterNode [" + rmNode.getNodeID() + "] " +
- "with queue wait time [" + estimatedQueueWaitTime + "] and " +
- "wait queue length [" + waitQueueLength + "]");
- } else {
- LOG.warn("IGNORING ClusterNode [" + rmNode.getNodeID() + "] " +
- "with queue wait time [" + estimatedQueueWaitTime + "] and " +
- "wait queue length [" + waitQueueLength + "]");
- }
+ ClusterNode clusterNode = this.clusterNodes.get(rmNode.getNodeID());
+ if (clusterNode == null) {
+ onNewNodeAdded(rmNode, opportunisticContainersStatus);
} else {
- if (rmNode.getState() != NodeState.DECOMMISSIONING &&
- (estimatedQueueWaitTime != -1 ||
- comparator == LoadComparator.QUEUE_LENGTH)) {
- currentNode
+ onExistingNodeUpdated(rmNode, clusterNode, opportunisticContainersStatus);
+ }
+ } finally {
+ writeLock.unlock();
+ }
+ }
+
+ protected void onNewNodeAdded(
+ RMNode rmNode, OpportunisticContainersStatus status) {
+ int opportQueueCapacity = status.getOpportQueueCapacity();
+ int estimatedQueueWaitTime = status.getEstimatedQueueWaitTime();
+ int waitQueueLength = status.getWaitQueueLength();
+
+ if (rmNode.getState() != NodeState.DECOMMISSIONING &&
+ (estimatedQueueWaitTime != -1 ||
+ comparator == LoadComparator.QUEUE_LENGTH)) {
+ this.clusterNodes.put(rmNode.getNodeID(),
+ new ClusterNode(rmNode.getNodeID())
.setQueueWaitTime(estimatedQueueWaitTime)
.setQueueLength(waitQueueLength)
- .updateTimestamp();
- LOG.debug("Updating ClusterNode [{}] with queue wait time [{}] and"
+ .setNodeLabels(rmNode.getNodeLabels())
+ .setQueueCapacity(opportQueueCapacity));
+ LOG.info("Inserting ClusterNode [" + rmNode.getNodeID() + "] " +
Review comment:
Updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri commented on pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
goiri commented on pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#issuecomment-674234207
I just have a comment about using logger as we are moving code around but I'm fine without changing that.
I'll wait for Yetus to run the tests and confirm but overall this is a clean refactor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri merged pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
goiri merged pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#issuecomment-675838322
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 12s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 31m 28s | trunk passed |
| +1 :green_heart: | compile | 1m 9s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | compile | 0m 54s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | checkstyle | 0m 42s | trunk passed |
| +1 :green_heart: | mvnsite | 0m 58s | trunk passed |
| +1 :green_heart: | shadedclient | 15m 40s | branch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 40s | trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 0m 36s | trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +0 :ok: | spotbugs | 1m 45s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 1m 42s | trunk passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 46s | the patch passed |
| +1 :green_heart: | compile | 0m 49s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javac | 0m 49s | the patch passed |
| +1 :green_heart: | compile | 0m 41s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | javac | 0m 41s | the patch passed |
| -0 :warning: | checkstyle | 0m 30s | hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager: The patch generated 16 new + 1 unchanged - 3 fixed = 17 total (was 4) |
| +1 :green_heart: | mvnsite | 0m 46s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedclient | 13m 55s | patch has no errors when building and testing our client artifacts. |
| +1 :green_heart: | javadoc | 0m 35s | the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 |
| +1 :green_heart: | javadoc | 0m 33s | the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| +1 :green_heart: | findbugs | 1m 42s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 92m 12s | hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. |
| | | 169m 35s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/2228 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 4afdf8e4fc64 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / b65e43fe386 |
| Default Java | Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01 |
| checkstyle | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/2/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| unit | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/2/artifact/out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-resourcemanager.txt |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/2/testReport/ |
| Max. process+thread count | 864 (vs. ulimit of 5500) |
| modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2228/2/console |
| versions | git=2.17.1 maven=3.6.0 findbugs=4.0.6 |
| Powered by | Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] BilwaST commented on pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
BilwaST commented on pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#issuecomment-675597847
Thanks @zhengbli for patch. Overall patch looks good me. Just a minor nit.
can you add a comment in below code which you removed?
`
if (!excludeFullNodes || !cNode.isQueueFull()) {
retList.add(cNode);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] BilwaST commented on pull request #2228: YARN-10399 Refactor NodeQueueLoadMonitor class to make it extendable
Posted by GitBox <gi...@apache.org>.
BilwaST commented on pull request #2228:
URL: https://github.com/apache/hadoop/pull/2228#issuecomment-676552916
> @BilwaST do you have further comments?
@goiri no..you can commit this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org