You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/23 08:18:22 UTC
[GitHub] [rocketmq-client-go] xujianhai666 opened a new pull request #429:
fix(consumer): brokerName not found when broker recover from machine creash
xujianhai666 opened a new pull request #429: fix(consumer): brokerName not found when broker recover from machine creash
URL: https://github.com/apache/rocketmq-client-go/pull/429
motivation:
when broker recover from machine creash, current routeData is not changed due to bug, which should be "change" as expected. then, mq can not be consumed or consuming mq can not update offset.
modification:
- check brokerData.BrokerAddresses len
Closes #428
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #429: [ISSUE
#428] fix(consumer): brokerName not found when broker recover from machine
crash.
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #429: [ISSUE #428] fix(consumer): brokerName not found when broker recover from machine crash.
URL: https://github.com/apache/rocketmq-client-go/pull/429
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io commented on issue #429:
fix(consumer): brokerName not found when broker recover from machine creash
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #429: fix(consumer): brokerName not found when broker recover from machine creash
URL: https://github.com/apache/rocketmq-client-go/pull/429#issuecomment-590039032
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=h1) Report
> Merging [#429](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/8e6f902f3d90f659d9b1c9918030adb2b3cd1c36?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/429/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #429 +/- ##
==========================================
- Coverage 24.92% 24.91% -0.01%
==========================================
Files 48 48
Lines 5476 5478 +2
==========================================
Hits 1365 1365
- Misses 3924 3926 +2
Partials 187 187
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/429/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.81% <0%> (-0.07%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=footer). Last update [8e6f902...6503379](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq-client-go] codecov-io edited a comment on issue #429:
fix(consumer): brokerName not found when broker recover from machine creash
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #429: fix(consumer): brokerName not found when broker recover from machine creash
URL: https://github.com/apache/rocketmq-client-go/pull/429#issuecomment-590039032
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=h1) Report
> Merging [#429](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=desc) into [native](https://codecov.io/gh/apache/rocketmq-client-go/commit/8e6f902f3d90f659d9b1c9918030adb2b3cd1c36?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-go/pull/429/graphs/tree.svg?width=650&token=CiV9ofPkG3&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## native #429 +/- ##
==========================================
- Coverage 24.92% 24.91% -0.01%
==========================================
Files 48 48
Lines 5476 5478 +2
==========================================
Hits 1365 1365
- Misses 3924 3926 +2
Partials 187 187
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [internal/route.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/429/diff?src=pr&el=tree#diff-aW50ZXJuYWwvcm91dGUuZ28=) | `9.81% <0%> (-0.07%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=footer). Last update [8e6f902...6503379](https://codecov.io/gh/apache/rocketmq-client-go/pull/429?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services