You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vincent Tran (Code Review)" <ge...@cloudera.org> on 2017/06/02 05:33:17 UTC
[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result
Vincent Tran has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7055
Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................
IMPALA-4418: Extra blank lines in query result
This change will remove the blank lines resulting
from the impala-shell client fetching on statements
that returns 0 row.
Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/7055/1
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result
Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has uploaded a new patch set (#2).
Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................
IMPALA-4418: Extra blank lines in query result
This change will remove the blank lines resulting
from the impala-shell client fetching on statements
that returns 0 row.
Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/7055/2
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7055/2/shell/impala_shell.py
File shell/impala_shell.py:
Line 919: if len(rows) == 0:
Comment on why we are doing this
http://gerrit.cloudera.org:8080/#/c/7055/2/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:
Line 294: # DROP and USE are exception cases that client does not fetch
Prefix with IMPALA-4418
Line 297: run_impala_shell_interactive("drop database if exists d1;")
Why not use a test similar to what was reported in the JIRA, i.e. issue a use? According to the JIRA the use should do a zero row fetch.
Better to avoid adding dummy dbs and tables, especially with short names. Those might conflict with local stuff a dev has.
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7055/3//COMMIT_MSG
Commit Message:
Line 11: that returns 0 row.
This change avoids printing blank lines when the Impala shell fetches 0 rows from a statement.
http://gerrit.cloudera.org:8080/#/c/7055/3/shell/impala_shell.py
File shell/impala_shell.py:
Line 922: # IMPALA-4418: Breaking out of the loop to prevent an empty newline printing
Break out of the loop to prevent printing an unnecessary empty line.
(the rest is clear from the code context)
http://gerrit.cloudera.org:8080/#/c/7055/3/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:
Line 293: # IMPALA-4418
We use this format
# IMPALA-4418: DROP AND USE ...
# ...
# ...
Line 294: # DROP and USE are exception cases that client does not fetch.
DROP and USE are generally exceptional statements where the client does not fetch. However, when preceded by a comment, the Impala shell treats them like any other statement and will try to fetch - receiving 0 rows. For statements returning 0 rows we do not want an empty line in stdout.
Line 296: # CREATE [DATABASE|TABLE] should trigger a 0 row fetch
Remove this part about CREATE in favor of the more general formulation above.
Maybe add another test that does not require create, e.g.:
select * from functional.alltypes limit 0
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: IMPALA-4418: Fixes extra blank lines in query result
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4418: Fixes extra blank lines in query result
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/740/
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result
Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change.
Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................
Patch Set 3:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/7055/3//COMMIT_MSG
Commit Message:
Line 11: that returns 0 row.
> This change avoids printing blank lines when the Impala shell fetches 0 row
Done
http://gerrit.cloudera.org:8080/#/c/7055/3/shell/impala_shell.py
File shell/impala_shell.py:
Line 922: # IMPALA-4418: Breaking out of the loop to prevent an empty newline printing
> Break out of the loop to prevent printing an unnecessary empty line.
Done
http://gerrit.cloudera.org:8080/#/c/7055/3/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:
Line 293: # IMPALA-4418
> We use this format
Done
Line 294: # DROP and USE are exception cases that client does not fetch.
> DROP and USE are generally exceptional statements where the client does not
Done
Line 296: # CREATE [DATABASE|TABLE] should trigger a 0 row fetch
> Remove this part about CREATE in favor of the more general formulation abov
Done
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result
Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has uploaded a new patch set (#4).
Change subject: IMPALA-4418: Fixes extra blank lines in query result
......................................................................
IMPALA-4418: Fixes extra blank lines in query result
This change avoids printing blank lines when the Impala
shell fetches 0 rows from a statement.
Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 18 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/7055/4
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result
Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has posted comments on this change.
Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7055/2/shell/impala_shell.py
File shell/impala_shell.py:
Line 919: if len(rows) == 0:
> Comment on why we are doing this
Done
http://gerrit.cloudera.org:8080/#/c/7055/2/tests/shell/test_shell_interactive.py
File tests/shell/test_shell_interactive.py:
Line 294: # DROP and USE are exception cases that client does not fetch
> Prefix with IMPALA-4418
Done
Line 297: run_impala_shell_interactive("drop database if exists d1;")
> Why not use a test similar to what was reported in the JIRA, i.e. issue a u
Good point. Done
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4418: Fixes extra blank lines in query result
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4418: Fixes extra blank lines in query result
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4418: Fixes extra blank lines in query result
......................................................................
IMPALA-4418: Fixes extra blank lines in query result
This change avoids printing blank lines when the Impala
shell fetches 0 rows from a statement.
Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Reviewed-on: http://gerrit.cloudera.org:8080/7055
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Alex Behm: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>
[Impala-ASF-CR] IMPALA-4418: Extra blank lines in query result
Posted by "Vincent Tran (Code Review)" <ge...@cloudera.org>.
Vincent Tran has uploaded a new patch set (#3).
Change subject: IMPALA-4418: Extra blank lines in query result
......................................................................
IMPALA-4418: Extra blank lines in query result
This change will remove the blank lines resulting
from impala-shell client fetching on statements
that returns 0 row.
Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
---
M shell/impala_shell.py
M tests/shell/test_shell_interactive.py
2 files changed, 16 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/7055/3
--
To view, visit http://gerrit.cloudera.org:8080/7055
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6e18ce36be07ee90a16b007b1e30d5255ef8a839
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Vincent Tran <vt...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Vincent Tran <vt...@cloudera.com>