[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3906: Enforce struct nullability in JSON raw reader (#3900) (#3904)

["tustvold (via GitHub)" <gi...@apache.org>]

tustvold commented on code in PR #3906:
URL: https://github.com/apache/arrow-rs/pull/3906#discussion_r1145017774


##########
arrow-json/src/raw/mod.rs:
##########
@@ -514,8 +514,8 @@ mod tests {
             Field::new(
                 "nested",
                 DataType::Struct(vec![
-                    Field::new("a", DataType::Int32, false),
-                    Field::new("b", DataType::Int32, false),
+                    Field::new("a", DataType::Int32, true),

Review Comment:
   This test was previously wrong :sob: 



##########
arrow-json/src/raw/mod.rs:
##########
@@ -594,7 +594,7 @@ mod tests {
                     "list2",
                     DataType::List(Box::new(Field::new(
                         "element",
-                        DataType::Struct(vec![Field::new("d", DataType::Int32, false)]),
+                        DataType::Struct(vec![Field::new("d", DataType::Int32, true)]),

Review Comment:
   As was this test



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org