You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/06/14 08:08:39 UTC
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1254: Fix: Graceful shutdown bugs
xavier-niu commented on a change in pull request #1254:
URL: https://github.com/apache/dubbo-go/pull/1254#discussion_r650463862
##########
File path: config/graceful_shutdown.go
##########
@@ -163,6 +163,7 @@ func waitForReceivingRequests() {
// ignore this step
return
}
+ providerConfig.ShutdownConfig.RejectRequest = true
Review comment:
destroyAllRegistries() removes information from registry, and the provider waits a while to ensure that all consumers get notification that the provider will go down, in other words, after performing waitAndAcceptNewRequests() there are no requests flowing into the provider. So I think the provider should reject the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org