[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #254: Ingress classname

[GitBox <gi...@apache.org>]

tao12345666333 commented on a change in pull request #254:
URL: https://github.com/apache/apisix-helm-chart/pull/254#discussion_r830593849



##########
File path: charts/apisix-dashboard/values.yaml
##########
@@ -86,9 +86,16 @@ service:
 
 ingress:
   enabled: false
+  # kubernetes ingress attribe ingressClassName,default to "apisix" 
+  classNamw: "apisix"

Review comment:
       ```suggestion
     className: "apisix"
   ```

##########
File path: charts/apisix-dashboard/templates/ingress.yaml
##########
@@ -24,6 +24,9 @@ apiVersion: extensions/v1beta1
 {{- end }}
 kind: Ingress
 metadata:
+  {{- if .Values.ingress.classNmae }}
+  ingressClassName: {{- .Values.ingress.classNmae -}}

Review comment:
       ```suggestion
     ingressClassName: {{- .Values.ingress.className -}}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org