You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/01/11 14:12:40 UTC
[GitHub] [hive] pvargacl opened a new pull request #1848: HIVE-24615: Remove unnecessary FileSystem listing from Initiator
pvargacl opened a new pull request #1848:
URL: https://github.com/apache/hive/pull/1848
### What changes were proposed in this pull request?
AcidUtils already returns the file list in base and delta directories if it does recursive listing on S3, listing those directories can be removed from the Initiator
### Why are the changes needed?
Performance improvement
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #1848: HIVE-24615: Remove unnecessary FileSystem listing from Initiator
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #1848:
URL: https://github.com/apache/hive/pull/1848#discussion_r555079627
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
##########
@@ -943,7 +947,7 @@ public String toString() {
* not needed {@link ParsedDeltaLight} should be used.
*/
@Immutable
- public static final class ParsedDelta extends ParsedDeltaLight {
+ public static final class ParsedDelta extends ParsedDeltaLight implements ParsedDirectory{
Review comment:
nit. missing space before {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter merged pull request #1848: HIVE-24615: Remove unnecessary FileSystem listing from Initiator
Posted by GitBox <gi...@apache.org>.
lcspinter merged pull request #1848:
URL: https://github.com/apache/hive/pull/1848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] lcspinter commented on pull request #1848: HIVE-24615: Remove unnecessary FileSystem listing from Initiator
Posted by GitBox <gi...@apache.org>.
lcspinter commented on pull request #1848:
URL: https://github.com/apache/hive/pull/1848#issuecomment-759321154
Thanks for the patch @pvargacl! Merged it into master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org