You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Ashish Singh <as...@cloudera.com> on 2016/04/22 23:13:32 UTC
Review Request 46586: SENTRY-1070: Rename kafka.superusers ->
super.users based on kafka docs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46586/
-----------------------------------------------------------
Review request for sentry, Dapeng Sun and Hao Hao.
Bugs: SENTRY-1070
https://issues.apache.org/jira/browse/SENTRY-1070
Repository: sentry
Description
-------
Rename kafka.superusers -> super.users based on kafka docs
Diffs
-----
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e0d767ec3db0c678eda3b5f929910651cd936fba
sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/KafkaTestServer.java 2a3b317b03b1cfa9394b503277ee4f81488dcc55
Diff: https://reviews.apache.org/r/46586/diff/
Testing
-------
Trivial patch. Is covered by existing end to end tests.
Thanks,
Ashish Singh
Re: Review Request 46586: SENTRY-1070: Rename kafka.superusers ->
super.users based on kafka docs
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46586/#review131049
-----------------------------------------------------------
Ship it!
Thank Ashish for your contribution. Please also update document if need.
- Dapeng Sun
On 四月 23, 2016, 5:13 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46586/
> -----------------------------------------------------------
>
> (Updated 四月 23, 2016, 5:13 a.m.)
>
>
> Review request for sentry, Dapeng Sun and Hao Hao.
>
>
> Bugs: SENTRY-1070
> https://issues.apache.org/jira/browse/SENTRY-1070
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Rename kafka.superusers -> super.users based on kafka docs
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java e0d767ec3db0c678eda3b5f929910651cd936fba
> sentry-tests/sentry-tests-kafka/src/main/java/org/apache/sentry/tests/e2e/kafka/KafkaTestServer.java 2a3b317b03b1cfa9394b503277ee4f81488dcc55
>
> Diff: https://reviews.apache.org/r/46586/diff/
>
>
> Testing
> -------
>
> Trivial patch. Is covered by existing end to end tests.
>
>
> Thanks,
>
> Ashish Singh
>
>