Unit Test Failures on Java 5

[Adam Lally <al...@alum.rpi.edu>]

Since there's no JIRA yet issues get logged to the dev list. :)

I'm getting two failures running the tests under Sun Java 1.5.

One failure is a test that uses xi:include, which doesn't work in Java
1.5.  I removed most of those from our tests but a couple are left.
Is it time to just remove this feature entirely?  In addition to not
working in Java 1.5 (unless you separately install xalan.jar), it's
also not supported in the CDE.

The other failure is a OutOfMemoryError in CasResetResizeTest.
Probably this is just due to a lower default max heap size in the Sun
Java vs. the IBM Java I was previously using to test.  I shall have to
figure out how to raise the max heap size in Maven.

-Adam

Re: Unit Test Failures on Java 5

[Adam Lally <al...@alum.rpi.edu>]

On 11/7/06, Michael Baessler <mb...@michael-baessler.de> wrote:
> +1 from my side, I also think that we can drop xi:include.
>
> - Michael

I should probably clarify that my patch doesn't remove xi:include
support for UIMA; it only modifies the testcase to use import instead.
 The actual removal can be done later.

-Adam

P.S. I'm trying to avoid the style of message that quotes the entire
preceding message at the bottom, as I saw in Ken's presentation that
this is not the Apache style.

Re: Unit Test Failures on Java 5

[Michael Baessler <mb...@michael-baessler.de>]

+1 from my side, I also think that we can drop xi:include.

- Michael

Thilo Goetz wrote:
> +1
>
> We have had <import .../> for a long time now as our standard include 
> mechanism, let's just drop xi:include.
>
> We also have one more test case failing with the IBM JDK 1.5 that I'm 
> working on, somehow other stuff keeps intervening.  (It's one of the 
> IteratorTest test cases).
>
> --Thilo
>
> Marshall Schor wrote:
>> Re removing xi:include - +1 from me.
>>
>> Adam Lally wrote:
>>> <snip
>>> One failure is a test that uses xi:include, which doesn't work in Java
>>> 1.5.  I removed most of those from our tests but a couple are left.
>>> Is it time to just remove this feature entirely?  In addition to not
>>> working in Java 1.5 (unless you separately install xalan.jar), it's
>>> also not supported in the CDE.
>>>
>
>
>

Re: Unit Test Failures on Java 5

[Thilo Goetz <tw...@gmx.de>]

+1

We have had <import .../> for a long time now as our standard include 
mechanism, let's just drop xi:include.

We also have one more test case failing with the IBM JDK 1.5 that I'm 
working on, somehow other stuff keeps intervening.  (It's one of the 
IteratorTest test cases).

--Thilo

Marshall Schor wrote:
> Re removing xi:include - +1 from me.
> 
> Adam Lally wrote:
>> <snip
>> One failure is a test that uses xi:include, which doesn't work in Java
>> 1.5.  I removed most of those from our tests but a couple are left.
>> Is it time to just remove this feature entirely?  In addition to not
>> working in Java 1.5 (unless you separately install xalan.jar), it's
>> also not supported in the CDE.
>>

Re: Unit Test Failures on Java 5

[Marshall Schor <ms...@schor.com>]

Re removing xi:include - +1 from me.

Adam Lally wrote:
> <snip
> One failure is a test that uses xi:include, which doesn't work in Java
> 1.5.  I removed most of those from our tests but a couple are left.
> Is it time to just remove this feature entirely?  In addition to not
> working in Java 1.5 (unless you separately install xalan.jar), it's
> also not supported in the CDE.
>

Re: Unit Test Failures on Java 5

[Adam Lally <al...@alum.rpi.edu>]

> We have to get patches working in any case.  Do attachments work?

That was the first thing I tried, but attachments don't seem to be
allowed on the list.  Next I tried just pasting the patchfile contents
into an email, but Thilo reported getting errors when trying to apply
the patch.  (When I then sent him the attachment directly, rather than
to the list, it worked.)  I'm not sure at what point the corruption of
the patch occurred.

-Adam

Re: Unit Test Failures on Java 5

[Marshall Schor <ms...@schor.com>]

We have to get patches working in any case.  Do attachments work?
-Marshall
Thilo Goetz wrote:
>
>
> Let's wait another day for your SVN accounts.  uuencode really takes 
> me way back to the early 90s.  I had no idea it still existed ;-)  If 
> for some reason your SVN accounts fail to be set up tomorrow, I'll 
> dust off that knowledge.
>
> --Thilo
>
>
>

Re: Unit Test Failures on Java 5

[Thilo Goetz <tw...@gmx.de>]

Adam Lally wrote:
>> One failure is a test that uses xi:include, which doesn't work in Java
>> 1.5.  I removed most of those from our tests but a couple are left.
>> Is it time to just remove this feature entirely?  In addition to not
>> working in Java 1.5 (unless you separately install xalan.jar), it's
>> also not supported in the CDE.
>>
>> The other failure is a OutOfMemoryError in CasResetResizeTest.
>> Probably this is just due to a lower default max heap size in the Sun
>> Java vs. the IBM Java I was previously using to test.  I shall have to
>> figure out how to raise the max heap size in Maven.
> 
> Here's a patch for both of these issues.  Since my previous attempt to
> send a patch file in an email body seemed to corrupt the patch, this
> time I am uuencoding it.
>  -Adam
<snip>

Let's wait another day for your SVN accounts.  uuencode really takes me 
way back to the early 90s.  I had no idea it still existed ;-)  If for 
some reason your SVN accounts fail to be set up tomorrow, I'll dust off 
that knowledge.

--Thilo

Re: Unit Test Failures on Java 5

[Adam Lally <al...@alum.rpi.edu>]

> One failure is a test that uses xi:include, which doesn't work in Java
> 1.5.  I removed most of those from our tests but a couple are left.
> Is it time to just remove this feature entirely?  In addition to not
> working in Java 1.5 (unless you separately install xalan.jar), it's
> also not supported in the CDE.
>
> The other failure is a OutOfMemoryError in CasResetResizeTest.
> Probably this is just due to a lower default max heap size in the Sun
> Java vs. the IBM Java I was previously using to test.  I shall have to
> figure out how to raise the max heap size in Maven.

Here's a patch for both of these issues.  Since my previous attempt to
send a patch file in an email body seemed to corrupt the patch, this
time I am uuencoding it.
  -Adam

begin 666 testFixesForJava15.patch
M26YD97@Z('5I;6%J+6-O<F4O<&]M+GAM;`T*/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/0T*+2TM('5I;6%J+6-O<F4O<&]M+GAM;`DH<F5V:7-I;VX@-#<P.3,S
M*0T**RLK('5I;6%J+6-O<F4O<&]M+GAM;`DH=V]R:VEN9R!C;W!Y*0T*0$`@
M+30Q+#4@*S0Q+#$T($!`#0H@"3PO9&5P96YD96YC:65S/@T*(`D\8G5I;&0^
M#0H@"0D\9FEN86Q.86UE/G5I;6$M8V]R93PO9FEN86Q.86UE/@T**PD)/'!L
M=6=I;G,^#0HK"0D)/'!L=6=I;CX-"BL)"0D)/&=R;W5P260^;W)G+F%P86-H
M92YM879E;BYP;'5G:6YS/"]G<F]U<$ED/@T**PD)"0D\87)T:69A8W1)9#YM
M879E;BUS=7)E9FER92UP;'5G:6X\+V%R=&EF86-T260^#0HK"0D)"3QC;VYF
M:6=U<F%T:6]N/@T**PD)"0D)/&%R9TQI;F4^+5AM>#,X-$T\+V%R9TQI;F4^
M#0HK"0D)"3PO8V]N9FEG=7)A=&EO;CX-"BL)"0D\+W!L=6=I;CX)"0T**PD)
M/"]P;'5G:6YS/@T*(`D\+V)U:6QD/@T*(#PO<')O:F5C=#X-"EP@3F\@;F5W
M;&EN92!A="!E;F0@;V8@9FEL90T*26YD97@Z('5I;6%J+6-O<F4O<W)C+W1E
M<W0O:F%V82]O<F<O87!A8VAE+W5I;6$O=71I;"]I;7!L+UA-3%!A<G-E<E]I
M;7!L5&5S="YJ879A#0H]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]#0HM+2T@=6EM
M86HM8V]R92]S<F,O=&5S="]J879A+V]R9R]A<&%C:&4O=6EM82]U=&EL+VEM
M<&PO6$U,4&%R<V5R7VEM<&Q497-T+FIA=F$)*')E=FES:6]N(#0W,#DS,RD-
M"BLK*R!U:6UA:BUC;W)E+W-R8R]T97-T+VIA=F$O;W)G+V%P86-H92]U:6UA
M+W5T:6PO:6UP;"]834Q087)S97)?:6UP;%1E<W0N:F%V80DH=V]R:VEN9R!C
M;W!Y*0T*0$`@+3(U+#8@*S(U+#<@0$`-"B!I;7!O<G0@:G5N:70N9G)A;65W
M;W)K+E1E<W1#87-E.PH@"B!I;7!O<G0@;W)G+F%P86-H92YU:6UA+E5)34%&
M<F%M97=O<FL["BMI;7!O<G0@;W)G+F%P86-H92YU:6UA+F%N86QY<VES7V5N
M9VEN92Y!;F%L>7-I<T5N9VEN941E<V-R:7!T:6]N.PH@:6UP;W)T(&]R9RYA
M<&%C:&4N=6EM82YA;F%L>7-I<U]E;F=I;F4N5&%E1&5S8W)I<'1I;VX["B!I
M;7!O<G0@;W)G+F%P86-H92YU:6UA+G1E<W0N:G5N:71?97AT96YS:6]N+DI5
M;FET17AT96YS:6]N.PH@:6UP;W)T(&]R9RYA<&%C:&4N=6EM82YU=&EL+EA-
M3$EN<'5T4V]U<F-E.PI`0"`M-C@L,S$@*S8Y+#(P($!`#0H@("!["B`@("`@
M=')Y"B`@("`@>PHM("`@("`@+R]*5&%L96YT06YD4W1R:6YG36%T8V@N>&UL
M(&-O;G1A:6YS('AI;F-L=61E<RP@"BL@("`@("`O+TI486QE;G1!;F13=')I
M;F=-871C:"YX;6P@8V]N=&%I;G,@:6UP;W)T<RP@"B`@("`@("`O+TI486QE
M;G1!;F13=')I;F=-871C:%]%>'!A;F1E9"YX;6P@:&%S(&AA9"!T:&5M(&UA
M;G5A;&QY(&5X<&%N9&5D"BT@("`@("!&:6QE('=I=&A826YC;'5D97,@/2!*
M56YI=$5X=&5N<VEO;BYG971&:6QE*")8;6Q087)S97)497-T+TI486QE;G1!
M;F13=')I;F=-871C:"YX;6PB*3L**R`@("`@($9I;&4@=VET:$EM<&]R=',@
M/2!*56YI=$5X=&5N<VEO;BYG971&:6QE*")8;6Q087)S97)497-T+TI486QE
M;G1!;F13=')I;F=-871C:"YX;6PB*3L*("`@("`@($9I;&4@;6%N=6%L;'E%
M>'!A;F1E9"`]($I5;FET17AT96YS:6]N+F=E=$9I;&4H(EAM;%!A<G-E<E1E
M<W0O2E1A;&5N=$%N9%-T<FEN9TUA=&-H7T5X<&%N9&5D+GAM;"(I.PH@("`@
M("`@"BT@("`@("`O+T%F=&5R('!A<W-I;F<@2E1A;&5N=$%N9%-T<FEN9TUA
M=&-H+GAM;"!T:')O=6=H('!R;V-E<W-826YC;'5D97,L"BL@("`@("`O+T%F
M=&5R('!A<G-I;F<@8F]T:"!F:6QE<R!A;F0@8V%L;&EN9R!R97-O;'9E26UP
M;W)T<RP*("`@("`@("\O=V4@<VAO=6QD('1H96X@8F4@86)L92!T;R!P87)S
M92!B;W1H(&9I;&5S(&%N9"!G970@:61E;G1I8V%L(')E<W5L=',N"BT@("`@
M("!834QI>F%B;&4@;V)J,2`](&U8;6Q087)S97(N<&%R<V4H;F5W(%A-3$EN
M<'5T4V]U<F-E*'=I=&A826YC;'5D97,I*3L*+2`@("`@(%A-3&EZ86)L92!O
M8FHR(#T@;5AM;%!A<G-E<BYP87)S92AN97<@6$U,26YP=713;W5R8V4H;6%N
M=6%L;'E%>'!A;F1E9"DI.PHM("`@("`@07-S97)T+F%S<V5R=$YO=$YU;&PH
M;V)J,2D[("`@(`HM("`@("`@07-S97)T+F%S<V5R=$YO=$YU;&PH;V)J,BD[
M("`@(`HM("`@("`@07-S97)T+F%S<V5R=$5Q=6%L<RAO8FHQ+&]B:C(I.R`*
M+2`@("`@(`HM("`@("`@+R]T<GD@<VEM:6QA<B!T97-T(&9O<B!826YC;'5D
M92!C;VYT86EN:6YG('AP;VEN=&5R"BT@("`@("!W:71H6$EN8VQU9&5S(#T@
M2E5N:71%>'1E;G-I;VXN9V5T1FEL92@B6&UL4&%R<V5R5&5S="]826YC;'5D
M95A0;VEN=&5R5&5S="YX;6PB*3L*+2`@("`@(&UA;G5A;&QY17AP86YD960@
M/2!*56YI=$5X=&5N<VEO;BYG971&:6QE*")8;6Q087)S97)497-T+UA);F-L
M=61E6%!O:6YT97)497-T7T5X<&%N9&5D+GAM;"(I.PHM("`@("`@"BT@("`@
M("`O+T%F=&5R('!A<W-I;F<@2E1A;&5N=$%N9%-T<FEN9TUA=&-H+GAM;"!T
M:')O=6=H('!R;V-E<W-826YC;'5D97,L"BT@("`@("`O+W=E('-H;W5L9"!T
M:&5N(&)E(&%B;&4@=&\@<&%R<V4@8F]T:"!F:6QE<R!A;F0@9V5T(&ED96YT
M:6-A;"!R97-U;'1S+@HM("`@("`@;V)J,2`](&U8;6Q087)S97(N<&%R<V4H
M;F5W(%A-3$EN<'5T4V]U<F-E*'=I=&A826YC;'5D97,I*3L*+2`@("`@(&]B
M:C(@/2!M6&UL4&%R<V5R+G!A<G-E*&YE=R!834Q);G!U=%-O=7)C92AM86YU
M86QL>45X<&%N9&5D*2D["BT@("`@("!!<W-E<G0N87-S97)T3F]T3G5L;"AO
M8FHQ*3L@"BT@("`@("`O+V]B:C$N=&]834PH4WES=&5M+F]U="D["BT@("`@
M("!!<W-E<G0N87-S97)T3F]T3G5L;"AO8FHR*3L@("`@"BT@("`@("!!<W-E
M<G0N87-S97)T17%U86QS*&]B:C$L;V)J,BD[(`HK("`@("`@06YA;'ES:7-%
M;F=I;F5$97-C<FEP=&EO;B!D97-C,2`]("A!;F%L>7-I<T5N9VEN941E<V-R
M:7!T:6]N*0HK("`@("`@("!M6&UL4&%R<V5R+G!A<G-E*&YE=R!834Q);G!U
M=%-O=7)C92AW:71H26UP;W)T<RDI.PHK("`@("`@06YA;'ES:7-%;F=I;F5$
M97-C<FEP=&EO;B!D97-C,B`]("A!;F%L>7-I<T5N9VEN941E<V-R:7!T:6]N
M*0HK("`@("`@("!M6&UL4&%R<V5R+G!A<G-E*&YE=R!834Q);G!U=%-O=7)C
M92AM86YU86QL>45X<&%N9&5D*2D["BL@("`@("!!<W-E<G0N87-S97)T3F]T
M3G5L;"AD97-C,2D[("`@(`HK("`@("`@07-S97)T+F%S<V5R=$YO=$YU;&PH
M9&5S8S(I.PHK("`@("`@07-S97)T+F%S<V5R=$5Q=6%L<RAD97-C,2YG971$
M96QE9V%T94%N86QY<VES16YG:6YE4W!E8VEF:65R<R@I+&1E<V,R+F=E=$1E
M;&5G871E06YA;'ES:7-%;F=I;F53<&5C:69I97)S*"DI.R`*("`@("!]"B`@
M("`@8V%T8V@@*$5X8V5P=&EO;B!E*0H@("`@('L*26YD97@Z('5I;6%J+6-O
M<F4O<W)C+W1E<W0O<F5S;W5R8V5S+UAM;%!A<G-E<E1E<W0O2E1A;&5N=$%N
M9%-T<FEN9TUA=&-H+GAM;`T*/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/0T*+2TM
M('5I;6%J+6-O<F4O<W)C+W1E<W0O<F5S;W5R8V5S+UAM;%!A<G-E<E1E<W0O
M2E1A;&5N=$%N9%-T<FEN9TUA=&-H+GAM;`DH<F5V:7-I;VX@-#<P.3,S*0T*
M*RLK('5I;6%J+6-O<F4O<W)C+W1E<W0O<F5S;W5R8V5S+UAM;%!A<G-E<E1E
M<W0O2E1A;&5N=$%N9%-T<FEN9TUA=&-H+GAM;`DH=V]R:VEN9R!C;W!Y*0T*
M0$`@+3(U+#$Q("LR-2PQ,2!`0`T*(`H@/&1E;&5G871E06YA;'ES:7-%;F=I
M;F53<&5C:69I97)S/@H@/&1E;&5G871E06YA;'ES:7-%;F=I;F4@:V5Y/2)*
M5&%L96YT(CX*+3QX:3II;F-L=61E(&AR968](DI486QE;G1!;FYO=&%T;W)?
M16YH86YC960N>&UL(B\^"BL\:6UP;W)T(&QO8V%T:6]N/2)*5&%L96YT06YN
M;W1A=&]R7T5N:&%N8V5D+GAM;"(O/@H@/"]D96QE9V%T94%N86QY<VES16YG
M:6YE/@H@"B`\9&5L96=A=&5!;F%L>7-I<T5N9VEN92!K97D](E-T<FEN9TUA
M=&-H(CX*+3QX:3II;F-L=61E(&AR968](E-T<FEN9TUA=&-H06YN;W1A=&]R
M,BYX;6PB+SX**SQI;7!O<G0@;&]C871I;VX](E-T<FEN9TUA=&-H06YN;W1A
M=&]R,BYX;6PB+SX*(#PO9&5L96=A=&5!;F%L>7-I<T5N9VEN93X*(#PO9&5L
M96=A=&5!;F%L>7-I<T5N9VEN95-P96-I9FEE<G,^"B`*26YD97@Z('5I;6%J
M+6-O<F4O<W)C+W1E<W0O<F5S;W5R8V5S+UAM;%!A<G-E<E1E<W0O2E1A;&5N
M=$%N;F]T871O<E]%;FAA;F-E9"YX;6P-"CT]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]/3T]
M/3T-"BTM+2!U:6UA:BUC;W)E+W-R8R]T97-T+W)E<V]U<F-E<R]8;6Q087)S
M97)497-T+TI486QE;G1!;FYO=&%T;W)?16YH86YC960N>&UL"2AR979I<VEO
M;B`T-S`Y,S,I#0HK*RL@=6EM86HM8V]R92]S<F,O=&5S="]R97-O=7)C97,O
M6&UL4&%R<V5R5&5S="]*5&%L96YT06YN;W1A=&]R7T5N:&%N8V5D+GAM;`DH
M=V]R:VEN9R!C;W!Y*0T*0$`@+3$Y+#@@*S$Y+#@@0$`-"B`@+2T^"B`*(#QT
M865$97-C<FEP=&EO;B!X;6QN<STB:'1T<#HO+W5I;6$N=V%T<V]N+FEB;2YC
M;VTO<F5S;W5R8V53<&5C:69I97(B/@HK/&9R86UE=V]R:TEM<&QE;65N=&%T
M:6]N/F]R9RYA<&%C:&4N=6EM82YJ879A/"]F<F%M97=O<FM);7!L96UE;G1A
M=&EO;CX*(#QP<FEM:71I=F4^=')U93PO<')I;6ET:79E/@HM/&9R86UE=V]R
M:TEM<&QE;65N=&%T:6]N/F]R9RYA<&%C:&4N=6EM82YJ879A/"]F<F%M97=O
M<FM);7!L96UE;G1A=&EO;CX*(#QA;FYO=&%T;W));7!L96UE;G1A=&EO;DYA
M;64^;W)G+F%P86-H92YR97-E87)C:"YT86QE;G1U:6UA+F%N;F]T871I;VYS
M+DI486QE;G1!;FYO=&%T;W)?16YH86YC960\+V%N;F]T871O<DEM<&QE;65N
I=&%T:6]N3F%M93X*("`*(#QA;F%L>7-I<T5N9VEN94UE=&%$871A/@H`
`
end