You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/01 10:30:48 UTC

[GitHub] [pulsar] hangc0276 commented on a change in pull request #11867: Added MetadataStore deleteRecursive operation

hangc0276 commented on a change in pull request #11867:
URL: https://github.com/apache/pulsar/pull/11867#discussion_r700086760



##########
File path: pulsar-metadata/src/test/java/org/apache/pulsar/metadata/MetadataStoreTest.java
##########
@@ -300,4 +300,30 @@ public void notificationListeners(String provider, String url) throws Exception
         assertEquals(n.getType(), NotificationType.ChildrenChanged);
         assertEquals(n.getPath(), key1);
     }
+
+    @Test(dataProvider = "impl")

Review comment:
       Should we add Timeout for this test? the `join()` operation will wait until completed, which may block the test




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org