[GitHub] [dolphinscheduler] devosend commented on issue #7717: [Bug] [UI Next] ESLint errors

[GitBox <gi...@apache.org>]

devosend commented on issue #7717:
URL: https://github.com/apache/dolphinscheduler/issues/7717#issuecomment-1003737681


   > > > > Please confirm this question if you have time. @songjianet
   > > > 
   > > > 
   > > > The format code can use the command `prettier`.
   > > 
   > > 
   > > yes, `prettier` is used to format the code. but the config of `.prettier.js` and `.eslintrc.js` conflict beause of `quotes` and `comma-dangle` rule is not effect in `.eslintrc.js`. by the way don't you report errors when you execute `npm run lint` locally? @songjianet
   > 
   > Yes, currently we have three people developing the new `ui`, and they can run normally using `webstorm` and `vscode` respectively.
   
   Thans for your answer，but I find `eslint-config-prettier` can't found `pretter`'s config, bease of `.pretter.js` is not support for `pretter`. the official profile names supported are as follows:
   ![image](https://user-images.githubusercontent.com/8847400/147881272-bf41b4f4-a400-4ec7-b02b-1d231fb03690.png).
   You can run `npm run prettier` correctly because the configuration file name is specified by the `--config` parameter.
   but `eslint` can't recognize it.
   In addition the code has other obvious styles for `eslint`. examples:
   ![image](https://user-images.githubusercontent.com/8847400/147881429-5818dee8-d0a8-4bab-8807-f6b84f0776d6.png)
   this file is `veiws/home/index.tsx`.
   Based on these I don't think you can run `npm run lint` without reporting errors. 
   Looking forward to your reply @songjianet 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org