[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #984: [KYUUBI #983] Refactor the basic abstraction of frontend service

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #984:
URL: https://github.com/apache/incubator-kyuubi/pull/984#discussion_r697394435



##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiFrontendService.scala
##########
@@ -19,30 +19,30 @@ package org.apache.kyuubi.server
 
 import org.apache.kyuubi.Logging
 import org.apache.kyuubi.config.KyuubiConf
-import org.apache.kyuubi.service.{AbstractFrontendService, BackendService, ServiceState, ThriftFrontendService}
+import org.apache.kyuubi.service.{AbstractFrontendService, BackendService, CompositeService, ServiceState, ThriftFrontendService}
 
 /**
  * A kyuubi frontend service is a kind of composite service, which used to
  * composite multiple frontend services for kyuubi server.
  */
 class KyuubiFrontendService private(name: String, be: BackendService)

Review comment:
       how about we change the name，it is no longer a FE




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org